Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up integration/behavioral tests #210

Open
tarkatronic opened this issue Aug 13, 2021 · 0 comments
Open

Set up integration/behavioral tests #210

tarkatronic opened this issue Aug 13, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@tarkatronic
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.

Some of the unit tests for this project are a bit obtuse and far from ideal. They do not fully encapsulate "real world" scenarios, and will have to be wholly rewritten for large changes, such as #122. It would be best to have a set of behavioral tests to ensure that this project behaves as we expect, from an end user's perspective, when run against an actual real life repository.

Describe the solution you'd like

  • Create a github.com/godaddy/tartufo-integration repository
  • Pre-seed the repository with some bad and some good commits
  • Populate several different config files in the repository
  • Build a test suite utilizing behave to run tartufo against this repository in a number of different ways

Describe alternatives you've considered

The alternative is our current state, which is no integration tests, which sucks.

Teachability, Documentation, Adoption, Migration Strategy

This should mainly involve an update to the contributing docs, asking users to write new Behave tests when behavior is changed.

@tarkatronic tarkatronic added the enhancement New feature or request label Aug 13, 2021
@tarkatronic tarkatronic added this to the Version 3.0 milestone Oct 27, 2021
@tarkatronic tarkatronic removed this from the Version 3.0 milestone Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant