Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A cluster cannot be used by more than one Go Server #118

Open
Matrikss opened this issue Jul 8, 2019 · 5 comments
Open

A cluster cannot be used by more than one Go Server #118

Matrikss opened this issue Jul 8, 2019 · 5 comments

Comments

@Matrikss
Copy link

Matrikss commented Jul 8, 2019

When the same cluster is used by 2 (or more) Go Servers, each Go Server plugin instance, based on the timeout for registering kills the other Go Server pods.

Example:
Go Server A creates an elastic agent A
Elastic agent A is running a job that takes more than the register timeout defined in Go Server B
Go Server B terminates Elastic agent A

From looking at the code, the criteria used to obtain the list of pods to check for register timeouts doesn't take into account the Go Server. It considers all the pods irregardless of the Go Server.

@arvindsv
Copy link
Member

arvindsv commented Jul 8, 2019

@Matrikss Which version of the plugin and of GoCD server are you using?

I wonder if the "Namespace" configuration parameter is supposed to be used for this. I'd assume you'd set the two GoCD servers to use different namespaces, and not the default, which is "default" namespace.

/cc @sheroy @GaneshSPatil

@Matrikss
Copy link
Author

Matrikss commented Jul 8, 2019

@arvindsv The version of the plugin is the 3.0.0-156

Both Go Servers were using the same default namespace.

@arvindsv
Copy link
Member

@Matrikss Oops. Nearly forgot to respond. For now, having the two GoCD servers use a different namespace should take care of it. We're considering something like a label to use as a part of the query selector. However, the challenge is that the pod YAML is not always controlled by GoCD. Users can control it. So, we will need to make sure that they use the right label in the pod YAML, that they have set up at the cluster level.

One of us will reply with more information, if anything comes of it. Thank you!

@ketan
Copy link
Member

ketan commented Aug 26, 2019

I think we should be able to apply the server identifier as a label and filter using that. As long as the 2 different servers use different identifiers, things should be allright.

@sgran
Copy link

sgran commented Oct 7, 2019

Agreed with @ketan's idea here. This would be quite nice for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants