Pipeline Config UI doesn't allow removal of material name

[JeroenOortwijn]

Issue Type

• Bug Report

Summary

Once you give a material a material name, you can't remove it anymore.

Basic environment details

• Go Version: 23.1.0 (16079-21e78c998e1eb35d8d489c1d3e3e9813dc18233a)
• JAVA Version: 17.0.6
• OS: Linux 5.4.0-147-generic

Steps to Reproduce

1. Create a new material without a material name (SVN in my case)
2. Notice that on the materials page, the name is equal to the URL
3. Click on the material and click on advanced settings
4. Fill something in the material name textbox
5. Click save
6. Click on the material and click on advanced settings and scroll all the way down
7. Remove everything in the material name textbox
8. Click save

Expected Results

It should close the dialog box and remove the material name.

Actual Results

The dialog box doesn't close, the scrollbar of the dialog box changes its size, but nothing else happens.
When you now scroll all the way up, you see the following notice:

Save failed. failed to save : Name is invalid. "" should conform to the pattern - [a-zA-Z0-9_\-]{1}[a-zA-Z0-9_\-.]*

Any other info

My pipeline suddenly stopped filling in the GO_REVISION environment variable (custom command echo %GO_REVISION% outputs %GO_REVISION%), so I tried to revert all the changes I had done but got stuck on reverting this.

It would also be nice if all error messages are always visible, independent of the position of the scroll bar.

[chadlwilson]

If you are an admin or pipeline group admin on the instance and want to workaround this via the UI you can use Admin > Config XML and edit the underlying XML configuration for the pipeline directly.

e.g replace

      <materials>
        <git url="https://github.com/gocd/gocd" shallowClone="true" materialName="gocd" />
      </materials>

with the below, removing the attribute completely.

      <materials>
        <git url="https://github.com/gocd/gocd" shallowClone="true"/>
      </materials>

[stale]

This issue has been automatically marked as stale because it has not had activity in the last 90 days.
If you can still reproduce this error on the master branch using local development environment or on the latest GoCD Release, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.