New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating an existing artifact store configuration with a new key silently fails (if in use?) #10735
Comments
This issue has been automatically marked as stale because it has not had activity in the last 90 days. |
Did you ever get around to finding a way to reproduce this? I'm not sure I quite follow how this problem is created here, and how much depends on the design of the plugin, optional vs required properties etc.
|
So I think this is a fairly niche issue, and perhaps unlikely to affect many others (and it is a one-time problem if you can fix it via the workaround listed in the OP as far as I remember), but to answer your questions for potential future readers:
|
This issue has been automatically marked as stale because it has not had activity in the last 90 days. |
Issue Type
Summary
I added a new property to an Artifact Plugin (for the Store Config) but when I then added a value for that property to an existing store, it was ignored and silently ignored.
Adding it directly to the config XML works.
Removing then re-adding the store is impossible because GoCD prevents removing stores that are referenced by pipelines (including pipelines from config repositories).
Basic environment details
22.2.0
17.0.4
Windows 10
Chrome 104.0.5112.101 (64-bit)
Steps to Reproduce
Will try setup a reproduction against the GoCD Docker plugin, otherwise, can provide the git hashes of the before/after from my current plugin once I release it next month.
(note to self, this would be something like a4aa31c and f1129d0, although those hashes are useless to this issue at present).
Reproduction probably requires two version of a plugin with different artifact store entries (I only observed the case where a new property is added, untried with removing properties) and then I'd imagine a pipeline using the config in the version 1 of the plugin.
Replace with the new version (2), then go to Admin > Artifact Stores > Edit (for chosen store), fill in the new value (appears correctly in the configuration dialog).
Verify by any of (I think):
Expected Results
Ideally, the property should be added.
Alternatively, the configuration should warn that it could not be / was not updated, and that the user should manually adjust the config XML.
Actual Results
Looks good, silently does nothing, returns whatever the behaviour of deserializing a non-existent property is (presumably depends on the plugin deserialization method).
Any other info
Can be worked around by manually editing the server XML config.
The text was updated successfully, but these errors were encountered: