common bench cases for rw tests

Author: gobwas

read_test.go

@@ -9,15 +9,15 @@ import (
 )
 
 func TestReadHeader(t *testing.T) {
-	for i, test := range append([]RWCase{
+	for i, test := range append([]RWTestCase{
 		{
 			Data: bits("0000 0000 0 1111111 10000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000"),
 			//                              _______________________________________________________________________
 			//                                                                 |
 			//                                                            Length value
 			Err: true,
 		},
-	}, RWCases...) {
+	}, RWTestCases...) {
 		t.Run(fmt.Sprintf("#%d", i), func(t *testing.T) {
 			r := bytes.NewReader(test.Data)
 			h, err := ReadHeader(r)
@@ -38,15 +38,7 @@ func TestReadHeader(t *testing.T) {
 }
 
 func BenchmarkReadHeader(b *testing.B) {
-	for i, bench := range []struct {
-		label  string
-		header Header
-	}{
-		{"t", Header{OpCode: OpText, Fin: true}},
-		{"t-m", Header{OpCode: OpText, Fin: true, Mask: NewMask()}},
-		{"t-m-u16", Header{OpCode: OpText, Fin: true, Length: len16, Mask: NewMask()}},
-		{"t-m-u64", Header{OpCode: OpText, Fin: true, Length: len64, Mask: NewMask()}},
-	} {
+	for i, bench := range RWBenchCases {
 		b.Run(fmt.Sprintf("%s#%d", bench.label, i), func(b *testing.B) {
 			bts := MustCompileFrame(Frame{Header: bench.header})
 			rds := make([]io.Reader, b.N)

rw_test.go

@@ -5,13 +5,25 @@ import (
 	"strings"
 )
 
-type RWCase struct {
+type RWTestCase struct {
 	Data   []byte
 	Header Header
 	Err    bool
 }
 
-var RWCases = []RWCase{
+type RWBenchCase struct {
+	label  string
+	header Header
+}
+
+var RWBenchCases = []RWBenchCase{
+	{"t", Header{OpCode: OpText, Fin: true}},
+	{"t-m", Header{OpCode: OpText, Fin: true, Mask: NewMask()}},
+	{"t-m-u16", Header{OpCode: OpText, Fin: true, Length: len16, Mask: NewMask()}},
+	{"t-m-u64", Header{OpCode: OpText, Fin: true, Length: len64, Mask: NewMask()}},
+}
+
+var RWTestCases = []RWTestCase{
 	{
 		Data: bits("1 001 0001 0 1100100"),
 		//          _ ___ ____ _ _______

write_test.go

@@ -8,7 +8,7 @@ import (
 )
 
 func TestWriteHeader(t *testing.T) {
-	for i, test := range RWCases {
+	for i, test := range RWTestCases {
 		t.Run(fmt.Sprintf("#%d", i), func(t *testing.T) {
 			buf := &bytes.Buffer{}
 			err := WriteHeader(buf, test.Header)
@@ -29,15 +29,7 @@ func TestWriteHeader(t *testing.T) {
 }
 
 func BenchmarkWriteHeader(b *testing.B) {
-	for _, bench := range []struct {
-		label  string
-		header Header
-	}{
-		{"t", Header{OpCode: OpText, Fin: true}},
-		{"t-m", Header{OpCode: OpText, Fin: true, Mask: NewMask()}},
-		{"t-m-u16", Header{OpCode: OpText, Fin: true, Length: len16, Mask: NewMask()}},
-		{"t-m-u64", Header{OpCode: OpText, Fin: true, Length: len64, Mask: NewMask()}},
-	} {
+	for i, bench := range RWBenchCases {
 		b.Run(bench.label, func(b *testing.B) {
 			for i := 0; i < b.N; i++ {
 				if err := WriteHeader(ioutil.Discard, bench.header); err != nil {