Fix lint

skjnldsv · st3iny · commit 3c98f7a802c2 · 2021-06-25T14:38:26.000+02:00
Signed-off-by: John Molakvoæ (skjnldsv) &lt;skjnldsv@protonmail.com&gt;
Signed-off-by: Richard Steinmetz &lt;richard@steinmetz.cloud&gt;
diff --git a/.stylelintignore b/.stylelintignore
@@ -0,0 +1 @@
+src/fonts
diff --git a/src/components/AppNavigation/AppNavigationHeader/AppNavigationHeaderDatePicker.vue b/src/components/AppNavigation/AppNavigationHeader/AppNavigationHeaderDatePicker.vue
@@ -73,7 +73,7 @@ export default {
 	filters: {
 		formatDateRage,
 	},
-	data: function() {
+	data() {
 		return {
 			isDatepickerOpen: false,
 		}
diff --git a/src/components/AppNavigation/CalendarList.vue b/src/components/AppNavigation/CalendarList.vue
@@ -39,9 +39,9 @@
 				:calendar="calendar" />
 		</template>
 		<!-- The header slot must be placed here, otherwise vuedraggable adds undefined as item to the array -->
-		<CalendarListItemLoadingPlaceholder
-			v-if="loadingCalendars"
-			#footer />
+		<template #footer>
+			<CalendarListItemLoadingPlaceholder v-if="loadingCalendars" />
+		</template>
 	</draggable>
 </template>
 
diff --git a/src/components/AppNavigation/CalendarList/CalendarListItem.vue b/src/components/AppNavigation/CalendarList/CalendarListItem.vue
@@ -183,7 +183,7 @@ export default {
 			required: true,
 		},
 	},
-	data: function() {
+	data() {
 		return {
 			// Rename action
 			showRenameLabel: true,
diff --git a/src/components/AppNavigation/CalendarList/CalendarListNew.vue b/src/components/AppNavigation/CalendarList/CalendarListNew.vue
@@ -101,7 +101,7 @@ export default {
 		ActionText,
 		AppNavigationItem,
 	},
-	data: function() {
+	data() {
 		return {
 			// Open state
 			isOpen: false,
diff --git a/src/components/AppNavigation/CalendarList/PublicCalendarListItem.vue b/src/components/AppNavigation/CalendarList/PublicCalendarListItem.vue
@@ -104,7 +104,7 @@ export default {
 			required: true,
 		},
 	},
-	data: function() {
+	data() {
 		return {
 			// copy subscription link:
 			showCopySubscriptionLinkLabel: true,
diff --git a/src/components/AppNavigation/CalendarList/Trashbin.vue b/src/components/AppNavigation/CalendarList/Trashbin.vue
@@ -236,35 +236,43 @@ export default {
 	max-width: 40vw;
 	margin: 2vw;
 }
+
 table {
 	width: 100%;
 }
+
 th, td {
 	padding: 4px;
 }
+
 th {
 	color: var(--color-text-maxcontrast)
 }
+
 .name {
 	// Take remaining width to prevent whitespace on the right side
 	width: 100vw;
 }
+
 .item {
 	display: flex;
 
 	.item-subline {
 		color: var(--color-text-maxcontrast)
 	}
 }
+
 .deletedAt {
 	text-align: right;
 }
+
 .footer {
 	color: var(--color-text-lighter);
 	text-align: center;
 	font-size: small;
 	margin-top: 16px;
 }
+
 .color-dot {
 	display: inline-block;
 	vertical-align: middle;
diff --git a/src/components/AppNavigation/Settings.vue b/src/components/AppNavigation/Settings.vue
@@ -157,7 +157,7 @@ export default {
 			default: false,
 		},
 	},
-	data: function() {
+	data() {
 		return {
 			savingBirthdayCalendar: false,
 			savingEventLimit: false,
diff --git a/src/components/AppNavigation/Settings/ImportScreenRow.vue b/src/components/AppNavigation/Settings/ImportScreenRow.vue
@@ -68,6 +68,8 @@ export default {
 			return this.$store.getters.getCalendarById(calendarId)
 		},
 		calendars() {
+			// TODO: remove once the false positive is fixed upstream
+			// eslint-disable-next-line vue/no-side-effects-in-computed-properties
 			const calendars = this.$store.getters.sortedCalendarFilteredByComponents(
 				this.file.parser.containsVEvents(),
 				this.file.parser.containsVJournals(),
diff --git a/src/components/Editor/Alarm/AlarmTimeUnitSelect.vue b/src/components/Editor/Alarm/AlarmTimeUnitSelect.vue
@@ -71,29 +71,29 @@ export default {
 
 			if (this.unit === 'seconds') {
 				options.push({
-					'label': this.$n('calendar', 'second', 'seconds', this.count),
-					'unit': 'seconds',
+					label: this.$n('calendar', 'second', 'seconds', this.count),
+					unit: 'seconds',
 				})
 			}
 
 			if (!this.isAllDay || ['minutes', 'hours'].indexOf(this.unit) !== -1) {
 				options.push({
-					'label': this.$n('calendar', 'minute', 'minutes', this.count),
-					'unit': 'minutes',
+					label: this.$n('calendar', 'minute', 'minutes', this.count),
+					unit: 'minutes',
 				})
 				options.push({
-					'label': this.$n('calendar', 'hour', 'hours', this.count),
-					'unit': 'hours',
+					label: this.$n('calendar', 'hour', 'hours', this.count),
+					unit: 'hours',
 				})
 			}
 
 			options.push({
-				'label': this.$n('calendar', 'day', 'days', this.count),
-				'unit': 'days',
+				label: this.$n('calendar', 'day', 'days', this.count),
+				unit: 'days',
 			})
 			options.push({
-				'label': this.$n('calendar', 'week', 'weeks', this.count),
-				'unit': 'weeks',
+				label: this.$n('calendar', 'week', 'weeks', this.count),
+				unit: 'weeks',
 			})
 
 			return options
diff --git a/src/components/Editor/FreeBusy/FreeBusy.vue b/src/components/Editor/FreeBusy/FreeBusy.vue
@@ -172,7 +172,7 @@ export default {
 				let title = attendee.commonName || attendee.uri.substr(7)
 				if (attendee === this.organizer) {
 					title = this.$t('calendar', '{organizer} (organizer)', {
-						organizer: title
+						organizer: title,
 					})
 				}
 
diff --git a/src/components/Editor/Invitees/AvatarParticipationStatus.vue b/src/components/Editor/Invitees/AvatarParticipationStatus.vue
@@ -150,6 +150,7 @@ export default {
 	opacity: .45;
 	position: relative;
 }
+
 .avatar-participation-status__text {
 	opacity: .45;
 	left: 69px;
diff --git a/src/components/Editor/Invitees/InviteesListItem.vue b/src/components/Editor/Invitees/InviteesListItem.vue
@@ -180,6 +180,7 @@ export default {
 .invitees-list-item__displayname {
 	margin-bottom: 17px;
 }
+
 .avatar-participation-status {
 	margin-top: 5px;
 }
diff --git a/src/components/Editor/Invitees/InviteesListSearch.vue b/src/components/Editor/Invitees/InviteesListSearch.vue
@@ -193,7 +193,7 @@ export default {
 					arr.push({
 						calendarUserType: 'INDIVIDUAL',
 						commonName: result.name,
-						email: email,
+						email,
 						isUser: false,
 						avatar: result.photo,
 						language: result.lang,
@@ -221,7 +221,7 @@ export default {
 				}
 
 				if (this.alreadyInvitedEmails.includes(principal.email)) {
-					return
+					return false
 				}
 
 				// We do not support GROUPS for now
diff --git a/src/components/Editor/Invitees/OrganizerListItem.vue b/src/components/Editor/Invitees/OrganizerListItem.vue
@@ -87,6 +87,7 @@ export default {
 .invitees-list-item__displayname {
 	margin-bottom: 13px;
 }
+
 .invitees-list-item__organizer-hint {
 	margin-bottom: 14px;
 }
diff --git a/src/components/Editor/Repeat/RepeatFreqSelect.vue b/src/components/Editor/Repeat/RepeatFreqSelect.vue
@@ -51,20 +51,20 @@ export default {
 	computed: {
 		options() {
 			return [{
-				'label': this.$t('calendar', 'never'),
-				'freq': 'NONE',
+				label: this.$t('calendar', 'never'),
+				freq: 'NONE',
 			}, {
-				'label': this.$n('calendar', 'day', 'days', this.count),
-				'freq': 'DAILY',
+				label: this.$n('calendar', 'day', 'days', this.count),
+				freq: 'DAILY',
 			}, {
-				'label': this.$n('calendar', 'week', 'weeks', this.count),
-				'freq': 'WEEKLY',
+				label: this.$n('calendar', 'week', 'weeks', this.count),
+				freq: 'WEEKLY',
 			}, {
-				'label': this.$n('calendar', 'month', 'months', this.count),
-				'freq': 'MONTHLY',
+				label: this.$n('calendar', 'month', 'months', this.count),
+				freq: 'MONTHLY',
 			}, {
-				'label': this.$n('calendar', 'year', 'years', this.count),
-				'freq': 'YEARLY',
+				label: this.$n('calendar', 'year', 'years', this.count),
+				freq: 'YEARLY',
 			}]
 		},
 		selected() {
diff --git a/src/components/Shared/CalendarPicker.vue b/src/components/Shared/CalendarPicker.vue
@@ -6,10 +6,10 @@
 		:options="calendars"
 		:value="calendar"
 		@select="change">
-		<template v-slot:singleLabel="scope">
+		<template #singleLabel="scope">
 			<CalendarPickerOption v-bind="scope.option" />
 		</template>
-		<template v-slot:option="scope">
+		<template #option="scope">
 			<CalendarPickerOption v-bind="scope.option" />
 		</template>
 	</Multiselect>
diff --git a/src/components/Shared/DatePicker.vue b/src/components/Shared/DatePicker.vue
@@ -40,7 +40,7 @@
 		@close="close"
 		@change="change"
 		@pick="pickDate">
-		<template v-slot:icon-calendar>
+		<template #icon-calendar>
 			<button
 				class="datetime-picker-inline-icon icon"
 				:class="{'icon-timezone': !isAllDay, 'icon-new-calendar': isAllDay, 'datetime-picker-inline-icon--highlighted': highlightTimezone}"
@@ -62,7 +62,7 @@
 		</template>
 		<template
 			v-if="!isAllDay"
-			v-slot:footer>
+			#footer>
 			<button
 				v-if="!showTimePanel"
 				class="mx-btn mx-btn-text"
diff --git a/src/fullcalendar/eventSources/eventSource.js b/src/fullcalendar/eventSources/eventSource.js
@@ -58,7 +58,7 @@ export default function(store) {
 					let timeRangeId
 					try {
 						timeRangeId = await store.dispatch('getEventsFromCalendarInTimeRange', {
-							calendar: calendar,
+							calendar,
 							from: start,
 							to: end,
 						})
diff --git a/src/fullcalendar/eventSources/freeBusyBlockedForAllEventSource.js b/src/fullcalendar/eventSources/freeBusyBlockedForAllEventSource.js
@@ -137,7 +137,7 @@ export default function(organizer, attendees, resources) {
 					groupId: 'free-busy-blocked-for-all',
 					start: slot.start.toISOString(),
 					end: slot.end.toISOString(),
-					resourceIds: resourceIds,
+					resourceIds,
 					display: 'background',
 					allDay: false,
 					backgroundColor: 'var(--color-text-maxcontrast)',
diff --git a/src/services/caldavService.js b/src/services/caldavService.js
@@ -35,7 +35,7 @@ const getClient = () => {
 	}, () => {
 		const headers = {
 			'X-Requested-With': 'XMLHttpRequest',
-			'requesttoken': getRequestToken(),
+			requesttoken: getRequestToken(),
 			'X-NC-CalDAV-Webcal-Caching': 'On',
 		}
 		const xhr = new XMLHttpRequest()
diff --git a/src/services/talkService.js b/src/services/talkService.js
@@ -33,7 +33,7 @@ import { generateUrl, generateOcsUrl } from '@nextcloud/router'
 export async function createTalkRoom(eventTitle = null) {
 	let response
 	try {
-		response = await HTTPClient.post(generateOcsUrl('apps/spreed/api/v1', 2) + `room`, {
+		response = await HTTPClient.post(generateOcsUrl('apps/spreed/api/v1', 2) + 'room', {
 			roomType: 3,
 			roomName: eventTitle || t('calendar', 'Chat room for event'),
 		})
diff --git a/src/store/calendarObjectInstance.js b/src/store/calendarObjectInstance.js
@@ -1437,7 +1437,7 @@ const actions = {
 		const defaultReminder = parseInt(settings.state.defaultReminder)
 		if (!isNaN(defaultReminder)) {
 			commit('addAlarmToCalendarObjectInstance', {
-				calendarObjectInstance: calendarObjectInstance,
+				calendarObjectInstance,
 				type: 'DISPLAY',
 				totalSeconds: defaultReminder,
 			})
@@ -1521,7 +1521,7 @@ const actions = {
 			if (original !== null && fork !== null && original.root !== fork.root) {
 				await dispatch('createCalendarObjectFromFork', {
 					eventComponent: fork,
-					calendarId: calendarId,
+					calendarId,
 				})
 			}
 		}
diff --git a/src/store/calendars.js b/src/store/calendars.js
@@ -984,17 +984,13 @@ const actions = {
 					components.push('VTODO')
 				}
 
-				try {
-					const response = await createCalendar(displayName, color, components, 0)
-					const calendar = mapDavCollectionToCalendar(response, context.getters.getCurrentUserPrincipal)
-					context.commit('addCalendar', { calendar })
-					context.commit('setCalendarForFileId', {
-						fileId: file.id,
-						calendarId: calendar.id,
-					})
-				} catch (error) {
-					throw error
-				}
+				const response = await createCalendar(displayName, color, components, 0)
+				const calendar = mapDavCollectionToCalendar(response, context.getters.getCurrentUserPrincipal)
+				context.commit('addCalendar', { calendar })
+				context.commit('setCalendarForFileId', {
+					fileId: file.id,
+					calendarId: calendar.id,
+				})
 			}
 		}
 
diff --git a/src/utils/timezone.js b/src/utils/timezone.js
@@ -61,7 +61,7 @@ export function getSortedTimezoneList(timezoneList = [], additionalTimezones = [
 		}
 
 		sortedByContinent[continent].regions.push({
-			label: label,
+			label,
 			cities: [],
 			timezoneId,
 		})
diff --git a/src/views/Calendar.vue b/src/views/Calendar.vue
@@ -121,7 +121,7 @@ export default {
 	computed: {
 		...mapGetters({
 			timezoneId: 'getResolvedTimezone',
-			'hasTrashBin': 'hasTrashBin',
+			hasTrashBin: 'hasTrashBin',
 		},
 		),
 		...mapState({
diff --git a/src/views/EditSidebar.vue b/src/views/EditSidebar.vue
@@ -46,13 +46,13 @@
 			</EmptyContent>
 		</template>
 
-		<template v-slot:header>
+		<template #header>
 			<IllustrationHeader :color="illustrationColor" :illustration-url="backgroundImage" />
 		</template>
 
 		<template
 			v-if="!isLoading && !isError"
-			v-slot:secondary-actions>
+			#secondary-actions>
 			<ActionLink v-if="hasDownloadURL"
 				icon="icon-download"
 				:href="downloadURL">
@@ -71,7 +71,7 @@
 
 		<template
 			v-if="!isLoading && !isError"
-			v-slot:description>
+			#description>
 			<PropertyCalendarPicker
 				v-if="showCalendarPicker"
 				:calendars="calendars"
diff --git a/src/views/EditSimple.vue b/src/views/EditSimple.vue

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ export default {`
`73`	`73`	`filters: {`
`74`	`74`	`formatDateRage,`
`75`	`75`	`},`
`76`		`- data: function() {`
	`76`	`+ data() {`
`77`	`77`	`return {`
`78`	`78`	`isDatepickerOpen: false,`
`79`	`79`	`}`
Original file line number	Diff line number	Diff line change
`@@ -236,35 +236,43 @@ export default {`
`236`	`236`	`max-width: 40vw;`
`237`	`237`	`margin: 2vw;`
`238`	`238`	`}`
	`239`	`+`
`239`	`240`	`table {`
`240`	`241`	`width: 100%;`
`241`	`242`	`}`
	`243`	`+`
`242`	`244`	`th, td {`
`243`	`245`	`padding: 4px;`
`244`	`246`	`}`
	`247`	`+`
`245`	`248`	`th {`
`246`	`249`	`color: var(--color-text-maxcontrast)`
`247`	`250`	`}`
	`251`	`+`
`248`	`252`	`.name {`
`249`	`253`	`// Take remaining width to prevent whitespace on the right side`
`250`	`254`	`width: 100vw;`
`251`	`255`	`}`
	`256`	`+`
`252`	`257`	`.item {`
`253`	`258`	`display: flex;`
`254`	`259`
`255`	`260`	`.item-subline {`
`256`	`261`	`color: var(--color-text-maxcontrast)`
`257`	`262`	`}`
`258`	`263`	`}`
	`264`	`+`
`259`	`265`	`.deletedAt {`
`260`	`266`	`text-align: right;`
`261`	`267`	`}`
	`268`	`+`
`262`	`269`	`.footer {`
`263`	`270`	`color: var(--color-text-lighter);`
`264`	`271`	`text-align: center;`
`265`	`272`	`font-size: small;`
`266`	`273`	`margin-top: 16px;`
`267`	`274`	`}`
	`275`	`+`
`268`	`276`	`.color-dot {`
`269`	`277`	`display: inline-block;`
`270`	`278`	`vertical-align: middle;`