zmq4: implement proper REQ and REP socket #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Feb 21, 2020
This fixes problems with REP sending messages to all connected peers rather than to the originating peer. The REQ/REP semantics now matches the recommended implementation behavior as specified in the ZMQ RFC. In particular: * REQ shall route outgoing messages to connected peers using a round-robin strategy * REQ shall block on sending, or return a suitable error, when it has no connected peers. * REP shall not block on sending Thus, this changes the behavior a bit as REP no longer blocks on Send. resolves go-zeromq#70
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
- Coverage 68.36% 67.86% -0.5%
=========================================
Files 27 27
Lines 2023 2247 +224
=========================================
+ Hits 1383 1525 +142
- Misses 546 621 +75
- Partials 94 101 +7
Continue to review full report at Codecov.
|
sbinet
reviewed
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problems with REP sending messages to all connected peers
rather than to the originating peer.
The REQ/REP semantics now matches the recommended implementation behavior as specified in the ZMQ RFC.
In particular:
round-robin strategy
connected peers.
Thus, this changes the behavior a bit as REP no longer blocks on Send.
resolves #70