Paging on the same request

[tormath1]

Hi,

I'm using the same request to perform a search with paging and the other without paging:

request := &ldap.SearchRequest{}
request.Scope = ldap.ScopeWholeSubtree
...
// First search, with paging
client.SearchWithPaging(request, 100)
...
// Second search, without paging but with a modified `filter`
client.Search(request)

My second request failed because request.Controls is not nil thanks to the method SearchWithPaging which appends ControlPaging to the request.

So I need to "reset" it manually:

...
request.Controls = []ldap.Controls{}
// Second search, without paging but with a modified `filter`
client.Search(request)

Thanks for your lib guys ! 😸

[johnweldon]

Would be nice to streamline this... feel free to propose a PR

[tormath1]

Hi !

We could remove this pointer to SearchRequest here.
But it won't be nice for compatibility reasons...

So we could simply reset searchRequest at the end of the method...

...
        // reset Controls attribute
        searchRequest.Controls = []ldap.Controls{}
	return searchResult, nil
...

What do you think ?

Thanks !

[johnweldon]

For that kind of approach, it's probably simplest to wrap the SearchWithPaging function with a custom function that does the reset... this has the added benefit of making it clear that it's your intent to do so. I don't think we want to introduce that side effect to the library implementation - it's potentially both surprising and annoying if someone doesn't want to reset the controls.

Thanks for the discussion!

[tormath1]

Ok, so something like SearchWithPagingWithControlsReset ?