Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

首页左下角的小蓝鸟和 FB 的图标换掉吧。 #206

Closed
kvii opened this issue Jan 31, 2024 · 4 comments
Closed

首页左下角的小蓝鸟和 FB 的图标换掉吧。 #206

kvii opened this issue Jan 31, 2024 · 4 comments

Comments

@kvii
Copy link
Contributor

kvii commented Jan 31, 2024

image

首页左下角的小蓝鸟和 FB 的图标对应分别是 blog 和 github 的 kratos discussions,并不是推特和脸书的链接。要不换掉这俩图标吧。

Copy link

dosubot bot commented Jan 31, 2024

🤖

Thanks for the suggestion! It sounds like you have a good idea for improving the repository. If you'd like to make this change, feel free to create a pull request with your proposed updates. Your contribution would be greatly appreciated!


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@mo3et
Copy link
Contributor

mo3et commented Feb 28, 2024

应该是当时贪方便,直接在theme上改了链接而已吧。如果有找到适合的icon,应该可以直接提个PR把他改了。

@kvii
Copy link
Contributor Author

kvii commented Feb 28, 2024

下面这俩怎么样?

  • blog 图标用 rss 链接的图标。因为 kratos blog 没有专属的图标。要是用 rss 图标的话,希望也能给个 rss 订阅功能。
image
  • discussions 图标就用 github discussions 的那个图标。不过这个图标辨识度不是很高,不加文字的话不好辨认。
image

不太清楚是不是还要考虑版权问题。突然感觉好麻烦啊……

@mo3et
Copy link
Contributor

mo3et commented Feb 28, 2024

那两个也不太对 ;)
因为这个docs生成是用静态页面工具生成的,看代码应该是用的 docusaurus 创建的,这些通常使用的话,是基于一些主题来生成的。所以上述我们提到的图标,应该是得在对应的theme里面找,不然图标的割裂感会很强(例如同时用了黑、白两个主题的图标)。
要修改的话可能是在 theme/footer 等地方进行修改,不过我对 react 和 docusaurus 不熟悉,可能需要研究一下对应的框架和主题。

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jun 1, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants