remove old params API usages (#25)

Signed-off-by: Iskander Sharipov <[email protected]>

Author: Iskander (Alex) Sharipov

captLocal_checker.go

@@ -11,13 +11,19 @@ func init() {
 	var info lintpack.CheckerInfo
 	info.Name = "captLocal"
 	info.Tags = []string{"style"}
+	info.Params = lintpack.CheckerParams{
+		"paramsOnly": {
+			Value: true,
+			Usage: "whether to restrict checker to params only",
+		},
+	}
 	info.Summary = "Detects capitalized names for local variables"
 	info.Before = `func f(IN int, OUT *int) (ERR error) {}`
 	info.After = `func f(in int, out *int) (err error) {}`
 
 	collection.AddChecker(&info, func(ctx *lintpack.CheckerContext) lintpack.FileWalker {
 		c := &captLocalChecker{ctx: ctx}
-		c.checkLocals = c.ctx.Params.Bool("checkLocals", true)
+		c.paramsOnly = info.Params.Bool("paramsOnly")
 		return astwalk.WalkerForLocalDef(c, ctx.TypesInfo)
 	})
 }
@@ -27,11 +33,11 @@ type captLocalChecker struct {
 	ctx *lintpack.CheckerContext
 
 	upcaseNames map[string]bool
-	checkLocals bool
+	paramsOnly  bool
 }
 
 func (c *captLocalChecker) VisitLocalDef(def astwalk.Name, _ ast.Expr) {
-	if !c.checkLocals && def.Kind != astwalk.NameParam {
+	if c.paramsOnly && def.Kind != astwalk.NameParam {
 		return
 	}
 	if ast.IsExported(def.ID.Name) {

checkers_test.go

@@ -7,7 +7,23 @@ import (
 	"github.com/go-lintpack/lintpack/linttest"
 )
 
-func TestCheckers(t *testing.T) { linttest.TestCheckers(t) }
+func TestCheckers(t *testing.T) {
+	allParams := map[string]map[string]interface{}{
+		"captLocal": {"paramsOnly": false},
+	}
+
+	for _, info := range lintpack.GetCheckersInfo() {
+		params := allParams[info.Name]
+		for key, p := range info.Params {
+			v, ok := params[key]
+			if ok {
+				p.Value = v
+			}
+		}
+	}
+
+	linttest.TestCheckers(t)
+}
 
 func TestIntegration(t *testing.T) { linttest.TestIntegration(t) }
 

elseif_checker.go

@@ -12,6 +12,12 @@ func init() {
 	var info lintpack.CheckerInfo
 	info.Name = "elseif"
 	info.Tags = []string{"style"}
+	info.Params = lintpack.CheckerParams{
+		"skipBalanced": {
+			Value: true,
+			Usage: "whether to skip balanced if-else pairs",
+		},
+	}
 	info.Summary = "Detects else with nested if statement that can be replaced with else-if"
 	info.Before = `
 if cond1 {
@@ -26,7 +32,7 @@ if cond1 {
 
 	collection.AddChecker(&info, func(ctx *lintpack.CheckerContext) lintpack.FileWalker {
 		c := &elseifChecker{ctx: ctx}
-		c.skipBalanced = c.ctx.Params.Bool("skipBalanced", true)
+		c.skipBalanced = info.Params.Bool("skipBalanced")
 		return astwalk.WalkerForStmt(c)
 	})
 }

underef_checker.go

@@ -30,7 +30,7 @@ v := a[5]`
 
 	collection.AddChecker(&info, func(ctx *lintpack.CheckerContext) lintpack.FileWalker {
 		c := &underefChecker{ctx: ctx}
-		c.skipRecvDeref = ctx.Params.Bool("skipRecvDeref", true)
+		c.skipRecvDeref = info.Params.Bool("skipRecvDeref")
 		return astwalk.WalkerForExpr(c)
 	})
 }