Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit error message, if solution is not accepted #564

Open
josojo opened this issue Feb 24, 2020 · 0 comments
Open

Explicit error message, if solution is not accepted #564

josojo opened this issue Feb 24, 2020 · 0 comments
Labels
Version2 Proposals for the version 2 contract

Comments

@josojo
Copy link
Contributor

josojo commented Feb 24, 2020

require(acceptingSolutions(batchId), "Solutions are no longer accepted for this batch");

This revert message is a little confusing because doesn't tell apart between "this batch is old", "this batch is in the future" and maybe "this batch is the current batch but it's already after the fourth minute"

It would be easier for other developers if the error would be explicit

@josojo josojo added the Version2 Proposals for the version 2 contract label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version2 Proposals for the version 2 contract
Projects
None yet
Development

No branches or pull requests

1 participant