Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change valid from logic to accept already valid orders #558

Open
koeppelmann opened this issue Feb 19, 2020 · 0 comments
Open

Change valid from logic to accept already valid orders #558

koeppelmann opened this issue Feb 19, 2020 · 0 comments
Labels
Version2 Proposals for the version 2 contract

Comments

@koeppelmann
Copy link
Member

placeValidFromOrders is the default function to use if a user wants to place multiple orders in one tx.
However - this function requires to specify a valid from. The intention is to have the option to place an order that is only valid in the future.

However - often a user wants to place multiple orders that are valid immediately. The issue is that this function will reject an order if the valid from batch ID already passed. A simple improvement would be to instead of rejecting such an order to simply replace the "valid from" with the current batch ID. This would even potentially make a small gas costs improvement since users could just use 0 for valid from if they want their orders active immediately.

@josojo josojo added the Version2 Proposals for the version 2 contract label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version2 Proposals for the version 2 contract
Projects
None yet
Development

No branches or pull requests

2 participants