Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring ES6 #533

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Refactoring ES6 #533

wants to merge 21 commits into from

Conversation

GM-Alex
Copy link

@GM-Alex GM-Alex commented Jul 14, 2018

This is a refactored version using ES6, adds i18n support, switches from less to sass, uses webpack, ports the slide transitions, the progress bar and the controls from reveal.js and adds some additional functionality. Maybe this could be used some day.

@utdrmac
Copy link

utdrmac commented Jul 14, 2018

This is awesome. Glad to see there's still life and interest in this project. Is there a README or documentation on the additional functionality?

@GM-Alex
Copy link
Author

GM-Alex commented Jul 15, 2018

@utdrmac No not yet. The options are (with defaults):

const defaults = {
  sourceUrl: null,
  ratio: '4:3',
  highlightStyle: 'default',
  highlightLines: false,
  highlightSpans: false,
  highlightInlineCode: false,
  highlightLanguage: '',
  slideNumberFormat: '%current% / %total%',
  cloneTarget: '_blank',
  excludedClasses: [],
  countIncrementalSlides: true,
  macros: {},
  transition: false,
  transitionSpeed: false,
  slideNumber: false,
  progressBar: false,
  controls: false,
  controlsTutorial: false,
  controlsLayout: 'bottom-right',
  controlsBackArrows: 'faded',
  folio: false,
  allowControl: true,
  navigation: {},
  translations: {}
};

For the ported settings (controls, transition, progress bar), see https://github.com/hakimel/reveal.js/#configuration.
allowControl disable the controller, useful for the new function SlideShow::setState which allows you to set the state (current slide, pause, blackout, mirrored). SlideShow::getState returns the current state. folio false makes the presentation full screen, true is the old style.

@utdrmac
Copy link

utdrmac commented Jul 15, 2018

Did you upgrade to the most recent version of marked or did you possibly switch to using CommonMark?

@GM-Alex
Copy link
Author

GM-Alex commented Jul 15, 2018

Edit: Sorry I over read the that you asked for the update of marked. No I don't.

@GM-Alex
Copy link
Author

GM-Alex commented Jul 15, 2018

I updated to marked 0.4.0, options for marked can be set using marked: {...} for the options.

@utdrmac
Copy link

utdrmac commented Aug 7, 2018

I'm not a github/git guru. What's the best way to test this PR?

@GM-Alex
Copy link
Author

GM-Alex commented Aug 8, 2018

I made an archive for you: https://github.com/GM-Alex/remark/releases/download/es6-rework/remark-es6.zip

I also add an easy way to use columns just use || as separator and it will make a new column at the same slide.

@jingsam
Copy link

jingsam commented Aug 28, 2018

@GM-Alex That's great works. Since the author has dropped maintenance of remarkjs, could you contact the author to transfer this project to you?

@jingsam
Copy link

jingsam commented Aug 28, 2018

I made a simple test, find that when sourceUrl set with a markdown file, I get these errors:

Uncaught TypeError: r.open is not a function
    at a.value (remark.min.js:1)
    at a.value (remark.min.js:1)
    at a.value (remark.min.js:1)
    at a.value (remark.min.js:1)
    at new a (remark.min.js:1)
    at e.value (remark.min.js:1)
    at (index):10

@utdrmac utdrmac mentioned this pull request Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants