Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor skill chat card handling to pass Actor and other documents by ID/UUID #195

Open
BadIdeasBureau opened this issue Jul 20, 2022 · 0 comments
Labels
Refactor This code's ol'! urgent

Comments

@BadIdeasBureau
Copy link
Collaborator

Currently, the chat cards pass the data on the originating actor and target by copying the data into the chat card. This potentially leads to issues where one of those actors is subsequently updated, and results in a lot of unnecessary data in the chat database.

Passing by ID (or more likely UUID) would allow an up to date copy of the data to be retrieved when needed - and as a bonus, would likely solve #193 in the process (as that is probably the result of the current method of data storage inadvertently skipping the deprecation path for changes in V10).

This should be doable synchronously (i.e. using fromUuidSync in v10), since I can't see that we would need a Document from a compendium for any of this.

@BadIdeasBureau BadIdeasBureau self-assigned this Jul 20, 2022
@Algor0113 Algor0113 added enhancement New feature or request urgent labels Sep 19, 2023
@Algor0113 Algor0113 added Refactor This code's ol'! and removed enhancement New feature or request labels Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor This code's ol'! urgent
Projects
None yet
Development

No branches or pull requests

2 participants