Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SSH PTY for NOKIA SROS (fix for #86) #107

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add SSH PTY for NOKIA SROS (fix for #86) #107

wants to merge 5 commits into from

Conversation

vitalisator
Copy link
Contributor

@vitalisator vitalisator commented Mar 22, 2020 •
edited

Fixes:

  • Fix debug options for SSH
  • add basic support for PTY and Nokia based devices fix Nokia-SROS #86
  • Support for VRF per router. $config['routers']['router1']['vrf'] = '1234';

@vitalisator vitalisator changed the title add SSH PTY for NOKIA SROS add SSH PTY for NOKIA SROS (fix for #86) Mar 22, 2020
@gmazoyer gmazoyer self-assigned this Mar 22, 2020
@gmazoyer gmazoyer added the bug label Mar 22, 2020
@gmazoyer
Copy link
Owner

Looks good to me. Maybe, for potential other types of router, it would be wise to put this kind of specific code in a dedicated and overridable function. I think that it would be wise and doable, but the Authentication object will need to know about the Router object we are dealing with somehow.

@vitalisator
Copy link
Contributor Author

yes, that was my thought too. But a I'm not so familiar with OOP stuff and currently structure of looking-glass.
what would be the points to touch?

gmazoyer
gmazoyer requested changes Mar 24, 2020
View reviewed changes
auth/ssh.php Outdated Show resolved Hide resolved
routers/router.php Show resolved Hide resolved
@vitalisator
- refactoring Authentication::send_command method
940d25b 
- add new Router::send_telnet_command and Router::send_ssh_command methods
  so this can be overwritten in Router vendor specific Instance
gmazoyer
gmazoyer reviewed Apr 8, 2020
View reviewed changes
Copy link
Owner

@gmazoyer gmazoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd like to keep the VRF work part out of this PR though. I think it worth creating another PR to introduce the VRF feature since this is a change that can be applied to multiple router types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmazoyer gmazoyer gmazoyer requested changes

Assignees

@gmazoyer gmazoyer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nokia-SROS
2 participants
@vitalisator @gmazoyer