Fix import location hierarchy

[trasher]

Q	A
Bug fix?	yes/no
New feature?	yes/no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	glpi-project/glpi-inventory-plugin#513 (and maybe #17106)

[trasher]

I'm a bit surprised location is created with the full name; I was ewpecting its name to be "Paris" only.

I'll dig into that if necessary when I'll be back.

[khaegebaert]

Hi, I've tried your solution as I have the issue with locations for users and inventory but got an error:

[2024-06-03 14:05:16] glpiphplog.CRITICAL: *** Uncaught Exception TypeError: str_replace(): Argument #3 ($subject) must be of type array|string, LDAP\Connection given in /opt/glpi/src/Html.php at line 318
Backtrace :
src/Html.php:318 str_replace()
: Html::cleanPostForTextArea()
src/Html.php:304 array_map()
src/CommonDBTM.php:1187 Html::cleanPostForTextArea()
src/CommonDBTM.php:1736 CommonDBTM->restoreInput()
src/AuthLDAP.php:2970 CommonDBTM->update()
src/AuthLDAP.php:404 AuthLDAP::ldapImportUserByServerId()
src/MassiveAction.php:1420 AuthLDAP::processMassiveActionsForOneItemtype()
src/MassiveAction.php:1398 MassiveAction->processForSeveralItemtypes()
front/massiveaction.php:62 MassiveAction->process()
public/index.php:82 require()

[trasher]

Either this is not related; either the proposed solution is not correct at all.

[trasher]

I cannot test LDAP import, but if proposed changes here cause an LDAP\Connection to be sent instead of a string; I guess there is a problem elsewhere.
Please also make sure you do not have plugins installed.

(restoreInput() method should not be called at all as far as I understand, since we're not dealing with an user input)

[khaegebaert]

Hi, tried the changes from cedric-anne, everything ok now, solves the bug and no errors.
Thanks