Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0.0] Users can approve changes of another users #19198

Open
2 tasks done
magaiverpr opened this issue Mar 13, 2025 · 2 comments · May be fixed by #19206
Open
2 tasks done

[11.0.0] Users can approve changes of another users #19198

magaiverpr opened this issue Mar 13, 2025 · 2 comments · May be fixed by #19206

Comments

@magaiverpr
Copy link

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

Version

11.0.0-alpha2

Bug description

I am testing the alpha version to see the change management improvements.

When asking for approval request with the option "Group user(s)", an user that is select can approve the change of anothers users.

Image

Relevant log output

Page URL

No response

Steps To reproduce

  1. create a change
  2. create an approval request with the field "Group user(s)"
  3. Select more than 1 user
  4. See with this user that they can approve the change as the other user.

Your GLPI setup information

GLPI information
GLPI: 11.0.0-dev ( => /usr/share/glpi)
Installation mode: RPM
Current language: en_GB
Server
Operating system: Linux glpi-6549ccff48-ck5rx 5.15.0-303.171.5.2.1.el9uek.x86_64 #​2 SMP Mon Dec 23 14:43:10 PST 2024 x86_64

PHP: 8.3.14 fpm-fcgi

PHP extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, random, Reflection, SPL, session, standard,
sockets, cgi-fcgi, bcmath, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, imap, intl, ldap, exif,
mysqlnd, PDO, Phar, SimpleXML, snmp, soap, sodium, sqlite3, tokenizer, xml, xmlwriter, xsl, mysqli, pdo_mysql, pdo_sqlite,
xmlreader, xmlrpc, zip, apcu, selinux, Zend OPcache

Setup: max_execution_time="30" memory_limit="128M" post_max_size="20M" safe_mode="" session.save_handler="files"
upload_max_filesize="20M" disable_functions=""

Web server: Apache/2.4.62 (AlmaLinux) ()

User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.0.0 Safari/537.36
Edg/134.0.0.0

Database:

Server Software: Percona Server (GPL), Release 4, Revision f0a32b8

Server Version: 8.0.13-4

Server SQL Mode: STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION

Requirements:
PHP version (8.3.14) is supported.
OS and PHP are relying on 64 bits integers.
Sessions configuration is OK.
Allocated memory is sufficient.
Following extensions are installed: dom, fileinfo, filter, libxml, json, simplexml, xmlreader, xmlwriter.
mysqli extension is installed.
curl extension is installed.
gd extension is installed.
intl extension is installed.
mbstring extension is installed.
zlib extension is installed.
bcmath extension is installed.
The constant
SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present.
openssl extension is installed.
Database engine version (8.0.13) is supported.
No files from previous GLPI version detected.
The log file has been created successfully.
Write access to /var/lib/glpi/files/_cache has been validated.
Write access to /var/lib/glpi/files/_cron has been validated.
Write access to /var/lib/glpi/files/data-documents has been validated.
Write access to /var/lib/glpi/files/_dumps has been validated.
Write access to /var/lib/glpi/files/_graphs has been validated.
Write access to /var/lib/glpi/files/_lock has been validated.
Write access to /var/lib/glpi/files/_pictures has been validated.
Write access to /var/lib/glpi/files/_plugins has been validated.
Write access to /var/lib/glpi/files/_rss has been validated.
Write access to /var/lib/glpi/files/_sessions has been validated.
Write access to /var/lib/glpi/files/_tmp has been validated.
Write access to /var/lib/glpi/files/_uploads has been validated.
For security reasons, SELinux
mode should be Enforcing.

Sessions configuration is secured.
exif extension is installed.
ldap extension is installed.
openssl extension is installed.
Following extensions are installed: bz2,
Phar, zip.
Zend OPcache extension is installed.
Following extensions are installed:
ctype, iconv, sodium.
Write access to
/usr/share/glpi/marketplace has been validated.
Access to timezone database (mysql)
is not allowed.

GLPI constants
GLPI_ROOT: "/usr/share/glpi"
GLPI_VERSION: "11.0.0-dev"
GLPI_SCHEMA_VERSION: "11.0.0-dev@4d5e5bd2f356eb8af6aec89aa610d816b605758f"
GLPI_MIN_PHP: "8.2"
GLPI_MAX_PHP: "8.3"
GLPI_YEAR: "2024"
GLPI_I18N_DIR: "/usr/share/glpi/locales"
GLPI_CONFIG_DIR: "/etc/glpi"
GLPI_MARKETPLACE_ALLOW_OVERRIDE: false
GLPI_VAR_DIR: "/var/lib/glpi/files"
GLPI_DOC_DIR: "/var/lib/glpi/files/data-documents"
GLPI_CRON_DIR: "/var/lib/glpi/files/_cron"
GLPI_DUMP_DIR: "/var/lib/glpi/files/_dumps"
GLPI_GRAPH_DIR: "/var/lib/glpi/files/_graphs"
GLPI_LOCK_DIR: "/var/lib/glpi/files/_lock"
GLPI_PICTURE_DIR: "/var/lib/glpi/files/_pictures"
GLPI_PLUGIN_DOC_DIR: "/var/lib/glpi/files/_plugins"
GLPI_RSS_DIR: "/var/lib/glpi/files/_rss"
GLPI_SESSION_DIR: "/var/lib/glpi/files/_sessions"
GLPI_TMP_DIR: "/var/lib/glpi/files/_tmp"
GLPI_UPLOAD_DIR: "/var/lib/glpi/files/_uploads"
GLPI_CACHE_DIR: "/var/lib/glpi/files/_cache"
GLPI_LOG_DIR: "/var/log/glpi"
GLPI_SYSTEM_CRON: true
GLPI_INSTALL_MODE: "RPM"
GLPI_ENVIRONMENT_TYPE: "production"
GLPI_MARKETPLACE_DIR: "/usr/share/glpi/marketplace"
GLPI_ALLOW_IFRAME_IN_RICH_TEXT: false
GLPI_SERVERSIDE_URL_ALLOWLIST: ["/^(https?|feed):\/\/[^@:]+(\/.*)?$/"]
GLPI_TELEMETRY_URI: "https://telemetry.glpi-project.org"
GLPI_NETWORK_MAIL: "[email protected]"
GLPI_NETWORK_SERVICES: "https://services.glpi-network.com"
GLPI_MARKETPLACE_ENABLE: 3
GLPI_MARKETPLACE_PRERELEASES: true
GLPI_MARKETPLACE_MANUAL_DOWNLOADS: true
GLPI_USER_AGENT_EXTRA_COMMENTS: ""
GLPI_DOCUMENTATION_ROOT_URL: "https://links.glpi-project.org"
GLPI_DISABLE_ONLY_FULL_GROUP_BY_SQL_MODE: "1"
GLPI_AJAX_DASHBOARD: "1"
GLPI_CALDAV_IMPORT_STATE: 0
GLPI_CENTRAL_WARNINGS: "1"
GLPI_TEXT_MAXSIZE: "4000"
GLPI_LOCAL_I18N_DIR: "/var/lib/glpi/files/_locales"
GLPI_INVENTORY_DIR: "/var/lib/glpi/files/_inventories"
GLPI_THEMES_DIR: "/var/lib/glpi/files/_themes"
GLPI_NETWORK_REGISTRATION_API_URL: "https://services.glpi-network.com/api/registration/"
GLPI_MARKETPLACE_PLUGINS_API_URI: "https://services.glpi-network.com/api/marketplace/"
Libraries
symfony/mailer not found
simplepie/simplepie version 1.8.0 in /usr/share/glpi/vendor/simplepie/simplepie/src
tecnickcom/tcpdf version 6.7.7 in /usr/share/glpi/vendor/tecnickcom/tcpdf
tecnickcom/tc-lib-barcode version in /usr/share/glpi/vendor/tecnickcom/tc-lib-barcode/src
sabre/dav version in /usr/share/glpi/vendor/sabre/dav/lib/DAV
sabre/http version in /usr/share/glpi/vendor/sabre/http/lib
sabre/uri version in /usr/share/glpi/vendor/sabre/uri/lib
sabre/vobject version in /usr/share/glpi/vendor/sabre/vobject/lib
laminas/laminas-i18n version in /usr/share/glpi/vendor/laminas/laminas-i18n/src
laminas/laminas-json version in /usr/share/glpi/vendor/laminas/laminas-json/src
monolog/monolog version in /usr/share/glpi/vendor/monolog/monolog/src/Monolog
sebastian/diff version in /usr/share/glpi/vendor/sebastian/diff/src
donatj/phpuseragentparser version in /usr/share/glpi/vendor/donatj/phpuseragentparser/src/UserAgent
elvanto/litemoji version in /usr/share/glpi/vendor/elvanto/litemoji/src
gettext/languages version in /usr/share/glpi/vendor/gettext/languages/src
symfony/console version in /usr/share/glpi/vendor/symfony/console
symfony/config version in /usr/share/glpi/vendor/symfony/config/Loader
symfony/dependency-injection version in /usr/share/glpi/vendor/symfony/dependency-injection
symfony/event-dispatcher version in /usr/share/glpi/vendor/symfony/event-dispatcher
symfony/filesystem version in /usr/share/glpi/vendor/symfony/filesystem
symfony/framework-bundle version in /usr/share/glpi/vendor/symfony/framework-bundle
symfony/http-foundation version in /usr/share/glpi/vendor/symfony/http-foundation
symfony/http-kernel version in /usr/share/glpi/vendor/symfony/http-kernel
symfony/routing version in /usr/share/glpi/vendor/symfony/routing
scssphp/scssphp version in /usr/share/glpi/vendor/scssphp/scssphp/src
laminas/laminas-mail version in /usr/share/glpi/vendor/laminas/laminas-mail/src/Protocol
laminas/laminas-mime version in /usr/share/glpi/vendor/laminas/laminas-mime/src
rlanvin/php-rrule version in /usr/share/glpi/vendor/rlanvin/php-rrule/src
ramsey/uuid version in /usr/share/glpi/vendor/ramsey/uuid/src
phpoffice/phpspreadsheet version in /usr/share/glpi/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet
psr/log version in /usr/share/glpi/vendor/psr/log/src
psr/simple-cache version in /usr/share/glpi/vendor/psr/simple-cache/src
psr/cache version in /usr/share/glpi/vendor/psr/cache/src
psr/container version in /usr/share/glpi/vendor/psr/container/src
league/csv version in /usr/share/glpi/vendor/league/csv/src
mexitek/phpcolors version in /usr/share/glpi/vendor/mexitek/phpcolors/src/Mexitek/PHPColors
guzzlehttp/guzzle version in /usr/share/glpi/vendor/guzzlehttp/guzzle/src
guzzlehttp/psr7 version in /usr/share/glpi/vendor/guzzlehttp/psr7/src
glpi-project/inventory_format version in /usr/share/glpi/vendor/glpi-project/inventory_format/lib/php
wapmorgan/unified-archive version in /usr/share/glpi/vendor/wapmorgan/unified-archive/src
paragonie/sodium_compat version in /usr/share/glpi/vendor/paragonie/sodium_compat/src
symfony/cache version in /usr/share/glpi/vendor/symfony/cache
html2text/html2text version in /usr/share/glpi/vendor/html2text/html2text/src
symfony/css-selector version in /usr/share/glpi/vendor/symfony/css-selector
symfony/dom-crawler version in /usr/share/glpi/vendor/symfony/dom-crawler
twig/twig version in /usr/share/glpi/vendor/twig/twig/src
twig/string-extra version in /usr/share/glpi/vendor/twig/string-extra
symfony/polyfill-ctype not found
symfony/polyfill-iconv not found
symfony/polyfill-mbstring not found
symfony/polyfill-php83 not found
league/oauth2-client version in /usr/share/glpi/vendor/league/oauth2-client/src/Provider
league/oauth2-google version in /usr/share/glpi/vendor/league/oauth2-google/src/Provider
thenetworg/oauth2-azure version in /usr/share/glpi/vendor/thenetworg/oauth2-azure/src/Provider
league/commonmark version in /usr/share/glpi/vendor/league/commonmark/src/Extension/CommonMark
egulias/email-validator version in /usr/share/glpi/vendor/egulias/email-validator/src
symfony/mime not found
apereo/phpcas version in /usr/share/glpi/vendor/apereo/phpcas/source
bacon/bacon-qr-code version in /usr/share/glpi/vendor/bacon/bacon-qr-code/src
robthree/twofactorauth version in /usr/share/glpi/vendor/robthree/twofactorauth/lib
ralouphie/getallheaders not found
symfony/html-sanitizer version in /usr/share/glpi/vendor/symfony/html-sanitizer
league/oauth2-server version in /usr/share/glpi/vendor/league/oauth2-server/src
league/html-to-markdown version in /usr/share/glpi/vendor/league/html-to-markdown/src
twig/markdown-extra version in /usr/share/glpi/vendor/twig/markdown-extra
webonyx/graphql-php version in /usr/share/glpi/vendor/webonyx/graphql-php/src
phpdocumentor/reflection-docblock version in /usr/share/glpi/vendor/phpdocumentor/reflection-docblock/src
symfony/property-access version in /usr/share/glpi/vendor/symfony/property-access
symfony/serializer version in /usr/share/glpi/vendor/symfony/serializer
symfony/property-info version in /usr/share/glpi/vendor/symfony/property-info
symfony/error-handler version in /usr/share/glpi/vendor/symfony/error-handler

Use TLS: none</pre></details><details><summary>SQL replicas</summary><pre>Not active</pre></details><details><summary>Notifications</summary><pre>Way of sending emails: PHP</pre></details>

Anything else?

No response

@trasher
Copy link
Contributor

trasher commented Mar 13, 2025

Alpha is quite old now, if you want to test GLPI v11 and report bugs, please use a recent nightly build.

@magaiverpr
Copy link
Author

magaiverpr commented Mar 13, 2025

Alpha is quite old now, if you want to test GLPI v11 and report bugs, please use a recent nightly build.

Hello,

updated my GLPI to te latest version (nightly build) but the problem persists.

And tested this in version 10.0.18, the problem not occurs.

@cconard96 cconard96 linked a pull request Mar 15, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants