Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive Redis calls #115

Open
fosron opened this issue Feb 27, 2024 · 1 comment
Open

Excessive Redis calls #115

fosron opened this issue Feb 27, 2024 · 1 comment

Comments

@fosron
Copy link

fosron commented Feb 27, 2024

Hey,

I think this method should not call cache in any kind of production environment. I understand safe guarding while development is happening, but excessive connections to cache server (if it is Redis or any other) seems redundant.

https://github.com/glorand/laravel-model-settings/blob/master/src/Traits/HasSettingsField.php#L106

I would suggest either a master switch for this check, an environment config, or altogether removing this method.

@glorand
Copy link
Owner

glorand commented Mar 13, 2024

If you have time maybe you can prepare a pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants