Skip to content

Commit 9409e72

Browse files
committed
refactor: leverage undecorated ORIGINAL_DRIVER in video consumer to avoid interfering with events consumers
1 parent 85141be commit 9409e72

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

spectrum/src/main/java/io/github/giulong/spectrum/utils/events/VideoConsumer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
import static io.github.giulong.spectrum.SpectrumEntity.HASH_ALGORITHM;
3131
import static io.github.giulong.spectrum.enums.Result.DISABLED;
32-
import static io.github.giulong.spectrum.extensions.resolvers.DriverResolver.DRIVER;
32+
import static io.github.giulong.spectrum.extensions.resolvers.DriverResolver.ORIGINAL_DRIVER;
3333
import static io.github.giulong.spectrum.extensions.resolvers.TestDataResolver.TEST_DATA;
3434
import static java.awt.image.BufferedImage.TYPE_INT_RGB;
3535
import static java.util.Comparator.comparingLong;
@@ -76,7 +76,7 @@ public void accept(final Event event) {
7676
final URL noVideoPng = Objects.requireNonNull(classLoader.getResource("no-video.png"));
7777
encoder.encodeImage(ImageIO.read(noVideoPng));
7878
} else {
79-
final Dimension dimension = chooseDimensionFor(contextManager.get(context, DRIVER, WebDriver.class), video);
79+
final Dimension dimension = chooseDimensionFor(contextManager.get(context, ORIGINAL_DRIVER, WebDriver.class), video);
8080

8181
for (File frame : frames) {
8282
encoder.encodeImage(resize(ImageIO.read(frame), dimension));

spectrum/src/test/java/io/github/giulong/spectrum/utils/events/VideoConsumerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
import static io.github.giulong.spectrum.SpectrumEntity.HASH_ALGORITHM;
3636
import static io.github.giulong.spectrum.enums.Result.DISABLED;
3737
import static io.github.giulong.spectrum.enums.Result.SUCCESSFUL;
38-
import static io.github.giulong.spectrum.extensions.resolvers.DriverResolver.DRIVER;
38+
import static io.github.giulong.spectrum.extensions.resolvers.DriverResolver.ORIGINAL_DRIVER;
3939
import static io.github.giulong.spectrum.extensions.resolvers.TestDataResolver.TEST_DATA;
4040
import static java.awt.image.BufferedImage.TYPE_INT_RGB;
4141
import static org.junit.jupiter.api.Assertions.*;
@@ -238,7 +238,7 @@ void acceptOneDuplicateFrame() throws IOException {
238238

239239
when(event.getContext()).thenReturn(context);
240240
when(contextManager.get(context, TEST_DATA, TestData.class)).thenReturn(testData);
241-
when(contextManager.get(context, DRIVER, WebDriver.class)).thenReturn(driver);
241+
when(contextManager.get(context, ORIGINAL_DRIVER, WebDriver.class)).thenReturn(driver);
242242

243243
awtSequenceEncoderMockedStatic.when(() -> AWTSequenceEncoder.createSequenceEncoder(videoFile, 1)).thenReturn(encoder);
244244
imageIOMockedStatic.when(() -> ImageIO.read(screenshot1)).thenReturn(bufferedImage);

0 commit comments

Comments
 (0)