Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with multiple include path in gitconfig #626

Open
guyzmo opened this issue May 7, 2017 · 4 comments
Open

Issue with multiple include path in gitconfig #626

guyzmo opened this issue May 7, 2017 · 4 comments

Comments

@guyzmo
Copy link
Contributor

guyzmo commented May 7, 2017

cf guyzmo/git-repo#153 when it edits the gitconfig where there is multiple includes, it does not save the modifications in one of the includes.

The place of usage is here. The place where the configuration is extracted is there and stored over there.

@Byron
Copy link
Member

Byron commented Jun 10, 2017

@guyzmo Would you be able and willing to contribute the fix?

@guyzmo
Copy link
Contributor Author

guyzmo commented Jun 10, 2017

ah, on that one I'm not sure how to solve this… how to correctly change a value and place it back in the included file it comes from?

We might need some brainstorm over here to figure a fix out

@Byron
Copy link
Member

Byron commented Jun 10, 2017

Yeah, that looks like a major overhaul on how the config file system is working. Not even git can do it, after all one must specify the destination of any configuration file changes.
A valid fix would be to not allow changing files with includes - just silently discarding changes is definitely not the correct way of handling this.

@guyzmo
Copy link
Contributor Author

guyzmo commented Jun 11, 2017

Well, another way would be to just pull the section where you do your change back in the main config, or maybe have it twice (can a section be coumpounded?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants