Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hadolint gives multiple errors and warnings for the Dockerfiles #736

Open
princerachit opened this issue Feb 27, 2022 · 0 comments
Open
Labels
bug Something isn't working team: workspace

Comments

@princerachit
Copy link
Contributor

Bug description

hadolint gives several error and warnings for the docker files of this repo. They used to exist for the older dazzle v1 images too.

Steps to reproduce

You can inspect Dockerfiles using hadolint e.g

gitpod /workspace/workspace-images (princerachit/use-google-artifact-713) $ docker run -v /workspace/workspace-images/:/myvol --rm -i hadolint/hadolint hadolint /myvol/chunks/lang-c/Dockerfile
/myvol/chunks/lang-c/Dockerfile:2 DL3006 warning: Always tag the version of an image explicitly
/myvol/chunks/lang-c/Dockerfile:9 DL3004 error: Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root
/myvol/chunks/lang-c/Dockerfile:9 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
/myvol/chunks/lang-c/Dockerfile:9 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check

such errors exist for multiple chunks.

Expected behavior

hadolint should not complain.

Example repository

No response

Anything else?

This issue was created as a result of research from #614 issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team: workspace
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant