-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Docker image not rebuild correctly after merging #19352
Labels
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Did anybody had a chance to take a look at that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
We have a very strange behavior with our Gitpod Setup using a custom Dockerfile.
We have a main branch A and a feature branch B. In B we're testing some new things so the Dockerfile differs slightly but is mainly equal to A. From time to time, we merge the main branch A into the feature branch B to keep it up to date.
In this case, the Docker Image is rebuild for B, but with the Dockerfile from A.
Sounds confusing? Yes it is :lau
I described the steps using a minimal example to show the problem:
Steps to reproduce
Start a Gitpod workspace for main
->
ls ~
should show onlymain-branch.info
Create a Feature Branch (test-branch) and change the Dockerfile to:
Start a Gitpod workspace for test-branch
->
ls ~
should showmain-branch.info
andtest-branch.info
-> So far everything is fine
Make a change to Dockerfile in main:
Start a Gitpod workspace for main
->
ls ~
should show onlymain-branch-refactored.info
Merge main into test-branch:
Start a Gitpod workspace for test-branch⚠️
->
ls ~
showsmain-branch-refactored.info
but not test-branch.infoThat's already confusing, as the code now doesn't represent the state anymore. So I tried rebuilding the image explicitely:
https://gitpod.io/#imagebuild/https://gitlab.com/<group>/<project>/-/tree/test-branch
-> Image is rebuild (you can see the logs, but you can see it's the wrong Dockerfile from main)
->
ls ~
showsmain-branch-refactored.info
but not test-branch.infoThe only thing that helps now is changing some line in the Dockerfile in test-branch. But this can't be the solution honestly.
Workspace affected
No response
Expected behavior
Example repository
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: