Skip to content

Create Pull Request action fails for remotes other than GitHub #4142

@eamodio

Description

@eamodio

Description

We need to implement getUrlForCreatePullRequest for each supported remote

protected getUrlForCreatePullRequest?(
base: { branch?: string; remote: { path: string; url: string } },
compare: { branch: string; remote: { path: string; url: string } },
): string | undefined;

We need to also ensure that we are correctly mapping self-hosted provider remotes to the proper type

Verification steps

  • For Azure test different types of origin URL:
    • SSH VSTS (oldschool) [email protected]:v3/bbbchiv/MyFirstProject/test
    • SSH AzureDevOps (modern) [email protected]:v3/bbbchiv2/MyFirstProject/MyFirstProject
    • HTTPS VSTS (oldschool) https://bbbchiv.visualstudio.com/MyFirstProject/_git/test
    • HTTPS AzureDevOps (modern) https://[email protected]/bbbchiv2/MyFirstProject/_git/MyFirstProject
  • GitLab
  • Bitbucket Cloud
  • Bitbucket Data Center
  • GitHub.com and GitHub Enterprise

Metadata

Metadata

Assignees

Labels

area-homeIssues or features related to Homeneeds-verificationRequest for verification

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions