Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PostgreSQL #14

Open
bronislav opened this issue May 18, 2017 · 4 comments
Open

Support for PostgreSQL #14

bronislav opened this issue May 18, 2017 · 4 comments

Comments

@bronislav
Copy link

I see that some SQL queries and migration are designed primary for MySQL and won't be able on PostgreSQL out-of-the-box.

Do you guys interested in supporting postgres? Will you accept PR?

@jnunemaker
Copy link
Contributor

We only use MySQL so that is our aim for github-ds. That said, I don't think we are opposed to a solid, well-tested PR for postgres support if it doesn't cause too much complexity. I'd really have to see it, but I'm definitely game to see it. 😄

@bronislav
Copy link
Author

@jnunemaker OK. Got it.

@jnunemaker
Copy link
Contributor

Its worth noting that GitHub::SQL pretty much works out of the box. See this gist for getting cast operators to work.

https://gist.github.com/jnunemaker/123be8db3d95d8386fc258f99e7fd99a

Also, I have a pg kv implementation sitting around somewhere. I'll try to find it and drop the link. I don't think it was perfectly compatible with github-ds kv, but supported the stuff that I needed.

@jnunemaker
Copy link
Contributor

Here is the postgres kv version.

https://gist.github.com/jnunemaker/f3954a1b82ac97750979389a37c573f2

I used jsonb to make it possible to query within the serialized value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants