Support v flag in JS regexps
#18727
Closed
Support v flag in JS regexps
#18727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. As for your suggested change, I would do it in a sightly different way, and we also have some in-progress (but paused) work for supporting the |
|
Thanks again. I've merged the above linked PR that implements the same thing. I'm closing this PR as it's now redundant. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added it to the
this.options.ecmaVersion() >= 9branch because it was introduced in ES2024, but it seems like you stopped tracking exact ECMAScript version since ES2020.Fixes #18721