Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable streaming while respecting proxy settings #2600

Open
NlightNFotis opened this issue Nov 12, 2024 · 1 comment
Open

Enable streaming while respecting proxy settings #2600

NlightNFotis opened this issue Nov 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@NlightNFotis
Copy link
Member

This is for the followup work to what's done in #2599 so that we provide a longer term fix for the issue described in #2593.

In #2599 we opted to deactivate the path that was using streaming, but the longer term, more robust fix, is to use streaming while detecting and respecting proxy settings that the client has setup.

@aeisenberg
Copy link
Contributor

Two options:

  1. Correctly apply proxy settings when we do streaming
  2. If we detect a proxy, disable streaming

Maybe 2 is a better option because proxies are only going to be set on self-hosted runners, which are more likely to cache the bundle. This means they would not get much benefit from streaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants