Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Better handling of unapproved grants in Grants Explorer #3731

Merged

Conversation

JacobHomanics
Copy link
Contributor

@JacobHomanics JacobHomanics commented Dec 4, 2024

Fixes: #3717

Description

The previous implementation was stuck in a loading state when a grant was unapproved leading to confusion. Now, it will properly display a message to the user if the grant is in an unapproved state.

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@JacobHomanics JacobHomanics requested review from a team as code owners December 4, 2024 22:13
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:19pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:19pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:19pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:19pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:19pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:19pm

Copy link
Member

@MasterHW MasterHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small but real QoL enhancement - lgtm!

@MasterHW MasterHW merged commit 8996d73 into gitcoinco:main Dec 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge case - grant approved then unapproved - display some info to the visitor?
2 participants