Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] DefaultGradient bug #3728

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JacobHomanics
Copy link
Contributor

Description

Removes the overlay gradient div and applies the gradiant to to the layout's children.

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@JacobHomanics JacobHomanics requested review from a team as code owners November 21, 2024 21:13
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:21am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:21am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:21am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:21am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:21am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:21am

@MasterHW
Copy link
Member

MasterHW commented Dec 9, 2024

like the new (better!) gradient, but i noticed when magnification is set to <100% on certain screens there are side boxes that don't exist on the live site. hopefully quick fix?
image

@JacobHomanics
Copy link
Contributor Author

like the new (better!) gradient, but i noticed when magnification is set to <100% on certain screens there are side boxes that don't exist on the live site. hopefully quick fix? image

Should be fixed now! Let me know if it still doesn't fit the requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants