Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Grants Stack Data Client #2582

Merged
merged 78 commits into from
Nov 14, 2023
Merged

Import Grants Stack Data Client #2582

merged 78 commits into from
Nov 14, 2023

Conversation

boudra
Copy link
Contributor

@boudra boudra commented Nov 14, 2023

This imports https://github.com/gitcoinco/grants-stack-data-client into this repo as a workspace package.

PR checklist

For every PR, make sure that these statements are true:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't contain type casts and non-null assertions.
  • Doesn't add @ts-ignore.
  • Doesn't disable lints.
  • Doesn't use useState just for computation - use plain variables instead.
  • Splits components into pure components that don't depend on external state or hooks.
  • Avoid embedding components within other components
  • Doesn't propagate optional values without good reason, doesn't mark property values as optional if that doesn't represent reality.
  • Doesn't duplicate existing code.
  • Parses out-of-domain data - this includes user input, API respones, on-chain data etc.
  • Doesn't contain commented out code.
  • Doesn't contain skipped or empty tests.
  • If this PR adds/updates any feature, it adds/updates its test script

Subjective - at the discretion of the reviewers

  • Does things as simply as possible, but not simpler.
  • Doesn't reinvent the wheel or create premature abstractions.
Description
Refers/Fixes

fixes #issuenumber

Copy link

gitstream-cm bot commented Nov 14, 2023

This PR is 96.56125268652134% new code.

1 similar comment
Copy link

gitstream-cm bot commented Nov 14, 2023

This PR is 96.56125268652134% new code.

Copy link

gitstream-cm bot commented Nov 14, 2023

🥷 Code experts: vacekj, bard

vacekj, bard have most 👩‍💻 activity in the files.
vacekj, bard have most 🧠 knowledge in the files.

See details

.gitignore

Activity based on git-commit:

vacekj bard
NOV
OCT
SEP 1 additions & 0 deletions
AUG
JUL 1 additions & 0 deletions
JUN

Knowledge based on git-blame:
vacekj: 56%

lefthook.yml

Activity based on git-commit:

vacekj bard
NOV
OCT 27 additions & 5 deletions
SEP 3 additions & 0 deletions
AUG
JUL 13 additions & 6 deletions
JUN 6 additions & 0 deletions

Knowledge based on git-blame:
bard: 71%
vacekj: 29%

package.json

Activity based on git-commit:

vacekj bard
NOV
OCT 9 additions & 7 deletions 3 additions & 1 deletions
SEP 10 additions & 6 deletions 5 additions & 0 deletions
AUG
JUL 2 additions & 2 deletions
JUN 5 additions & 13 deletions

Knowledge based on git-blame:
vacekj: 53%
bard: 14%

packages/common/package.json

Activity based on git-commit:

vacekj bard
NOV
OCT 5 additions & 1 deletions
SEP
AUG
JUL 5 additions & 4 deletions
JUN

Knowledge based on git-blame:
vacekj: 85%

pnpm-lock.yaml

Activity based on git-commit:

vacekj bard
NOV 678 additions & 828 deletions
OCT 216 additions & 68 deletions 653 additions & 76 deletions
SEP 5514 additions & 9303 deletions 1931 additions & 1080 deletions
AUG 7291 additions & 5024 deletions
JUL 1820 additions & 511 deletions
JUN 278 additions & 2225 deletions

Knowledge based on git-blame:
vacekj: 70%
bard: 5%

pnpm-workspace.yaml

Activity based on git-commit:

vacekj bard
NOV
OCT
SEP 1 additions & 0 deletions
AUG
JUL
JUN 0 additions & 1 deletions

Knowledge based on git-blame:
vacekj: 86%

To learn more about /:\ gitStream - Visit our Docs

@boudra boudra merged commit 85ffd7b into main Nov 14, 2023
28 checks passed
@boudra boudra deleted the feat/grants-stack-data-client branch November 14, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants