Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated INSTALL.md #581

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated INSTALL.md #581

wants to merge 1 commit into from

Conversation

sundowatch
Copy link

@sundowatch sundowatch commented Jun 21, 2020

Updated Windows installation guide

closes #580

@LukasFritzeDev
Copy link
Collaborator

Thanks for your mega request 🙂

The only difference to the current installation process described for windows is that you need to add the directory \Git\bin manually to your %PATH%. Is this still the case if you copy the executable file to C:\Program Files (x86)\Git\usr\bin as recommended in the documentation (instead of Program Files)?

If so, it would be great to have this addition right there in the doc (underneath the main description), and not in an complete new chapter with duplicated installation instructions.

@sundowatch
Copy link
Author

Actually my edit is enough for whole installation. But didn't removed yours. Package is so much easy to install on Windows.

I mean Git installation folder by \Git\bin

@LukasFritzeDev
Copy link
Collaborator

Sorry. I don't quite understand what you mean. The instructions you followed are obviously different from the ones we recommend in the documentation. In my opinion, your instructions are more complicated than the recommended way. You download the complete repo, we recommend to download only the single file you need.

Could please try our recommended way and check if it works?

@sundowatch
Copy link
Author

sundowatch commented Jun 23, 2020

My only recommandation is that:

git clone https://github.com/git-ftp/git-ftp.git

copy git-ftp file to C:\Program Files\Git\bin directory

add C:\Program Files\Git\bin to %PATH%

That's all enough for installation on Windows.

So many people have encountered so much problem on the installation on Windows. I've asked a question on stackoverflow this issue.

@LukasFritzeDev
Copy link
Collaborator

Yeah I got that. Thats your changes.

But … by using git clone you download the complete repository with all its history and the unneeded files. But you just need one file.

Our recommendation is:

curl https://raw.githubusercontent.com/git-ftp/git-ftp/master/git-ftp > /bin/git-ftp

where /bin is usually a symlink to C:\Program Files (x86)\Git\usr\bin (see here) This downloads only the one file you need (and nothing else) and will place it in the directory. The end result is the same but without all the junk of the complete repo on your system. So I don’t get the benefit of downloading the complete repository.

But since I can’t test this on Windows it might be true that you may need to manually add the directory to your path.
And that's exactly what I tried to say in my first comment here:

The only difference to the current installation process described for windows is that you need to add the directory \Git\bin manually to your %PATH%. Is this still the case if you copy the executable file to C:\Program Files (x86)\Git\usr\bin as recommended in the documentation (instead of Program Files)?

I think you just copied the file to an other directory (C:\Program Files\Git\bin) which is not in the PATH by default. Therefore you need to manually add it to the PATH. If you copy the file to the correct directory it would be available without manually adding it.

But as I said, that’s just a guess – I can’t test this.

@sundowatch
Copy link
Author

sundowatch commented Jun 23, 2020

Aaahhh you're right, I didn't get it.

If you want me to check it on windows with video record, I can do it.

@LukasFritzeDev
Copy link
Collaborator

This would be great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md update suggestions
2 participants