refactor: versionning des variables applicatives #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
changed the title
vperron
reviewed
Dec 11, 2024
| SIB_URL = os.getenv("SIB_URL") | ||
| if SIB_URL: | ||
| SIB_SMTP_URL = os.path.join(SIB_URL, "smtp/email") | ||
| SIB_CONTACTS_URL = os.path.join(SIB_URL, "contacts/import") |
There was a problem hiding this comment.
nit: idealement faut utiliser urljoin, sinon ton os.path.join n'est pas très différent de juste une concaténation ! attention au comportement quand le SIB_URL contient déjà un path par contre.
pas grave du tout, je le dis en passant.
| SIB_URL = os.getenv("SIB_URL", "https://test.com") | ||
| SIB_SMTP_URL = os.path.join(SIB_URL, "smtp/email") | ||
| SIB_CONTACTS_URL = os.path.join(SIB_URL, "contacts/import") | ||
| SIB_API_KEY = os.getenv("SIB_API_KEY", "key_to_be_set") |
There was a problem hiding this comment.
pourquoi pas. après, j'aurais peut etre laissé vide en dev, et mis ça en test; comme ça ça crashe quand meme en dev et le dev sait qu'il faut MAJ la valeur, par contre les tests vont tourner en mode mock.
vperron
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Versionner les variables applicatives de la communauté
🎸 Permettre le démarrage rapide d'une instance locale avec les variables prépositionnées en
devType de changement
🚧 technique
Points d'attention
🦺 suppression
.env.template🦺 hydrater par défaut les variables dans
dev.py🦺 faire casser par défaut en l'absence de variables dans
base.pyTODO :
test.pypour les variablesSIBbase.pypre-run.shetpre-build.sh