Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify LONG_DESCRIPTION in setup.py and use delvewheel to repair Windows wheels #70

Open
ulupo opened this issue Aug 25, 2022 · 0 comments

Comments

@ulupo
Copy link
Collaborator

ulupo commented Aug 25, 2022

I think the reason for

giotto-ph/setup.py

Lines 29 to 30 in 780f456

if platform.system() == "Windows":
LONG_DESCRIPTION = "giotto-ph at https://github.com/giotto-ai/giotto-ph"
(which is absent in pyflagser and giotto-tda) and for the fact that we don't include a Giotto logo here is that issues arise when building Windows wheels due to the different treatment of newline characters between Windows and Unix.

giotto-ai/pyflagser#80 fixed this in pyflagser by using a sed command we already used in giotto-tda and pyflagser Azure pipelines. I suggest we do the same here (and include a Giotto logo in the README).

Finally, also in giotto-ai/pyflagser#80 I introduced delvewheel to repair Windows wheels, and I suggest we can consider doing it here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant