Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky multithreading tests #68

Open
ulupo opened this issue Aug 17, 2022 · 2 comments
Open

Investigate flaky multithreading tests #68

ulupo opened this issue Aug 17, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@ulupo
Copy link
Collaborator

ulupo commented Aug 17, 2022

The tests for consistency of multithreaded results with single-threaded results are flaky, see e.g. https://github.com/giotto-ai/giotto-ph/runs/7875382240?check_suite_focus=true.

I'm not saying this implies there is a bug in the C++ backend, but it would be good to know exactly why they sometimes fail.

@ulupo ulupo added the help wanted Extra attention is needed label Aug 17, 2022
@MonkeyBreaker
Copy link
Collaborator

I might be wrong, but looking at the logs, the issue seems related to too slow:

Unreliable test timings! On an initial run, this test took 640.08ms, which exceeded the deadline of 500.00ms, but on a subsequent run it took 62.90 ms, which did not. If you expect this sort of variability in your test timings, consider turning deadlines off for this test by setting deadline=None.

I will investigate deeper there, but it might be less critical that I first ready your description 😅

@ulupo
Copy link
Collaborator Author

ulupo commented Aug 17, 2022

There are definitely assertion errors in some of these tests too, but I linked to the wrong one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants