Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add pre-commit #101

Closed
SauravMaheshkar opened this issue Jul 19, 2022 · 2 comments Β· Fixed by #102
Closed

[Proposal] Add pre-commit #101

SauravMaheshkar opened this issue Jul 19, 2022 · 2 comments Β· Fixed by #102
Assignees
Labels
enhancement New feature or request

Comments

@SauravMaheshkar
Copy link

Hey maintainers πŸ‘‹πŸ½ β˜• , I noticed that most of (if not all) the steps of the Python Coding Style can be automated via pre-commit such as flake8 and pytest or even the ones in the GH actions such as mypy. Having pre-commit would make that process much easier and enforce that the developers follow coding conventions. Maybe this could even help with #67 if we add black as a hook

Additional context
Although this would add pre-commit as a dependency for the project.

@SauravMaheshkar SauravMaheshkar added the enhancement New feature or request label Jul 19, 2022
@raphaelreinauer raphaelreinauer self-assigned this Jul 22, 2022
@raphaelreinauer
Copy link
Collaborator

Thanks for the suggestion, @SauravMaheshkar ! Great idea. I have added pre-commit as a dependency in the project and a pre-commit config file. I have also added black as a hook. Let me know if there's anything else you think we should add.

@SauravMaheshkar
Copy link
Author

#102 looks good πŸ‘πŸ½

@matteocao matteocao linked a pull request Aug 5, 2022 that will close this issue
3 tasks
matteocao added a commit that referenced this issue Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants