You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On line 64, we know that type is a number or integer, so the ternary condition type === 'string' will never be true. This means if newVal is NaN, it will never be set to an empty string and will always be set to 0. I'm not sure if that is an issue, but wanted to flag this.
The text was updated successfully, but these errors were encountered:
While refactoring to TypeScript (#456), I noticed a potential issue within the following snippet:
react-json-schema-form-builder/src/formBuilder/CardEnumOptions.js
Lines 55 to 66 in 58ed4fc
On line 64, we know that
type
is a number or integer, so the ternary conditiontype === 'string'
will never be true. This means ifnewVal
is NaN, it will never be set to an empty string and will always be set to 0. I'm not sure if that is an issue, but wanted to flag this.The text was updated successfully, but these errors were encountered: