Issue #20: do not unmarshal empty response body

gildas · gildas · commit d813f663f3b4 · 2024-10-15T16:35:12.000+09:00
diff --git a/request.go b/request.go
@@ -237,9 +237,11 @@ func Send(options *Options, results interface{}) (*Content, error) {
 				return nil, errors.WithStack(err)
 			}
 			log.Tracef("Response body in %s: %s", time.Since(start), resContent.LogString(uint64(options.ResponseBodyLogSize)))
-			err = json.Unmarshal(resContent.Data, results)
-			if err != nil {
-				return resContent, errors.JSONUnmarshalError.WrapIfNotMe(err)
+			if resContent.Length > 0 {
+				err = json.Unmarshal(resContent.Data, results)
+				if err != nil {
+					return resContent, errors.JSONUnmarshalError.WrapIfNotMe(err)
+				}
 			}
 			return resContent, nil
 		}

Original file line number	Diff line number	Diff line change
`@@ -237,9 +237,11 @@ func Send(options Options, results interface{}) (Content, error) {`
`237`	`237`	`return nil, errors.WithStack(err)`
`238`	`238`	`}`
`239`	`239`	`log.Tracef("Response body in %s: %s", time.Since(start), resContent.LogString(uint64(options.ResponseBodyLogSize)))`
`240`		`- err = json.Unmarshal(resContent.Data, results)`
`241`		`- if err != nil {`
`242`		`- return resContent, errors.JSONUnmarshalError.WrapIfNotMe(err)`
	`240`	`+ if resContent.Length > 0 {`
	`241`	`+ err = json.Unmarshal(resContent.Data, results)`
	`242`	`+ if err != nil {`
	`243`	`+ return resContent, errors.JSONUnmarshalError.WrapIfNotMe(err)`
	`244`	`+ }`
`243`	`245`	`}`
`244`	`246`	`return resContent, nil`
`245`	`247`	`}`