Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support saving selected content from iframes #1400

Open
unikitty37 opened this issue Feb 22, 2024 · 1 comment
Open

Support saving selected content from iframes #1400

unikitty37 opened this issue Feb 22, 2024 · 1 comment

Comments

@unikitty37
Copy link

Describe the bug
When trying to save a medium.com page that has been proxied through 12ft.io in order to make it readable, the badge appears on the icon when trying to save the page, but no status is shown at the bottom left and the page is never saved.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to https://12ft.io/proxy?q=https://benmukebo.medium.com/session-cookies-vs-a-devise-jwt-for-authenticating-users-in-ruby-on-rails-fd923a0586a0
  2. Select some part of the article (I selected the body of the article, without "about the author" footer)
  3. Right-click the SingleFile icon and choose Save Selection

Expected behaviour
The status indicator appears at the bottom left of the page, then the page is saved to the configured destination.

Screenshots

Environment

  • OS: macOS 13.6.1 (22G313)
  • Browser: Vivaldi
  • Version: 6.5.3206.59 (Stable channel) (arm64)

Additional context
I was unable to visit the page directly without using 12ft.io as it only shows the first couple of paragraphs, and demands I fork over personal data in order to read the rest. That is not going to happen under any circumstances, so I need SingleFile to work with the proxied page in order to save the content.

(To anyone reading this who publishes content on medium.com, please consider publishing on the open web instead!)

@gildas-lormeau
Copy link
Owner

Thank you for the detailed report. In fact the page is displayed in an iframe and today SingleFile does not support saving selected content in an iframe. That's the technical reason why it doesn't work.

It is possible in Firefox to workaround this problem easily by selecting "This Frame > Show only this frame" in the context menu before saving the selection. Unfortunately, Chromium doesn't offer this option via the context menu. You have to find the frame URL with the Dev Tools, for example, and open the URL (e.g. https://12ft.io/api/proxy?q=https%3A%2F%2Fbenmukebo.medium.com%2Fsession-cookies-vs-a-devise-jwt-for-authenticating-users-in-ruby-on-rails-fd923a0586a0) in a new tab.

@gildas-lormeau gildas-lormeau changed the title Pages proxied through 12ft.io cause SingleFile to loop forever and are not saved Support saving selected content from iframes May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants