Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback not fired when skipping first step in react-joyride #1121

Open
JoonSukCho opened this issue Dec 31, 2024 · 0 comments
Open

Callback not fired when skipping first step in react-joyride #1121

JoonSukCho opened this issue Dec 31, 2024 · 0 comments

Comments

@JoonSukCho
Copy link

JoonSukCho commented Dec 31, 2024

🐛 Bug Report

Custom overlay control issue in react-joyride when skipping the first step with a custom overlay implementation - callback function not executing.

Steps to Reproduce

  1. Set up react-joyride with disableOverlay={true}
  2. Implement custom overlay controlled by callback status
  3. Click skip button on first step
  4. Observe callback not firing

Current Behavior

  • Callback function not executed when clicking skip on first step
  • Custom overlay remains visible and uncontrollable
  • Skip action changes internal status but doesn't trigger callback

Expected Behavior

  • Callback should fire on skip action regardless of step position
  • Custom overlay should be properly controlled through callback status

Additional Context

  • Issue only occurs with custom overlay implementation
  • Works as expected with default overlay disableOverlay={false}, (The overlay disappears, but the callback not being executed remains an issue.)
  • Code analysis shows callback intentionally not fired when no previous step exists
  • Need confirmation if intended behavior or bug

Environment

react-joyride version: 3.0.0-7
React version: 19.0.0
Next.js version: 15.1.2

Repository Link

https://github.com/JoonSukCho/react-joyride-example

Running the Code

yarn        # install dependencies
yarn dev    # run development server
c-schicho added a commit to c-schicho/react-joyride that referenced this issue Jan 28, 2025
c-schicho added a commit to c-schicho/react-joyride that referenced this issue Jan 28, 2025
c-schicho added a commit to c-schicho/react-joyride that referenced this issue Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant