-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor issues #19
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Great script, i think it is the most complete i found, I already implemented it. Some minor issues:
I found class setting restrictive, it could allow for multiple class entry favoring css code reuse when you do bring your own, without going:
For instance:
Can none of the parent containters of 'mainNav' can be floated nor absolute, but only fixed? I had to change the layout to comply to that requirement. Why is it so?
It would be nice if you specify in REAME that options are default values, and some are required. Somewhat obvious but at first when I read
var nav = priorityNav.init();
was all there was needed to initialize, It didn't work.The text was updated successfully, but these errors were encountered: