Fixed implicit global variable on regex

ghiscoding · Dec 2, 2015 · a194fb7 · a194fb7
1 parent 9fcd5f8
commit a194fb7
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 9 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-validation-ghiscoding",
-  "version": "1.4.14",
+  "version": "1.4.15",
   "author": "Ghislain B.",
   "description": "Angular-Validation Directive and Service (ghiscoding)",
   "main": [

diff --git a/dist/angular-validation.min.js b/dist/angular-validation.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-validation-ghiscoding",
-  "version": "1.4.14",
+  "version": "1.4.15",
   "author": "Ghislain B.",
   "description": "Angular-Validation Directive and Service (ghiscoding)",
   "main": "app.js",

diff --git a/readme.md b/readme.md
@@ -1,5 +1,5 @@
 #Angular Validation (Directive / Service)
-`Version: 1.4.14`
+`Version: 1.4.15`
 ### Form validation after user stop typing (default 1sec).
 
 Forms Validation with Angular made easy! Angular-Validation is an angular directive/service with locales (languages) with a very simple approach of defining your `validation=""` directly within your element to validate (input, textarea, etc) and...that's it!!! The directive/service will take care of the rest!

diff --git a/src/validation-common.js b/src/validation-common.js
@@ -497,7 +497,6 @@ angular
       var self = this;
       var isConditionValid = true;
       var isFieldValid = true;
-      var regex;
       var validator;
       var validatedObject = {};
 
@@ -991,7 +990,7 @@ angular
         isWellFormed = true;
       }else {
         // run the Regex test through each iteration, if required (\S+) and is null then it's invalid automatically
-        regex = new RegExp(validator.pattern);
+        var regex = new RegExp(validator.pattern, validator.patternFlag);
         isWellFormed = ((!validator.pattern || validator.pattern.toString() === "/\\S+/" || (!!rules && validator.pattern === "required")) && strValue === null) ? false : regex.test(strValue);
       }
 
@@ -1274,7 +1273,7 @@ angular
           isValid = false;
         } else {
           // run the Regex test through each iteration, if required (\S+) and is null then it's invalid automatically
-          regex = new RegExp(validator.pattern, validator.patternFlag);
+          var regex = new RegExp(validator.pattern, validator.patternFlag);
           isValid = ((!validator.pattern || validator.pattern.toString() === "/\\S+/" || (!!rules && validator.pattern === "required")) && strValue === null) ? false : regex.test(strValue);
         }
       }