Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sails 0.12? #225

Closed
mikedevita opened this issue Mar 8, 2016 · 7 comments
Closed

Support sails 0.12? #225

mikedevita opened this issue Mar 8, 2016 · 7 comments

Comments

@mikedevita
Copy link
Contributor

Hey is there a plan to update this repo for sails 0.12 support?

@ghaiklor
Copy link
Owner

ghaiklor commented Mar 9, 2016

@mikedevita hey. Yes, I'm working on another project now. I will update generator with some fixes and Sails upgrade in few days.

@Fr33maan
Copy link

Hi @ghaiklor, after almost a year I tried to do that but tests fails.
I cloned the repo, updated package.json, npm install and run tests.

Could you give me some advices to solve issues ? I don't understand the stack trace

@ghaiklor
Copy link
Owner

@L1br3 do not update dependencies if you want to have working version. Otherwise, you need to migrate current codebase to new API of dependencies.

@Fr33maan
Copy link

Fr33maan commented Jan 16, 2017

I tried it with just updating sails to 0.12.4 and I've got exactly the same failures.
Note that I'm handling what we said here -> #238

@BraunreutherA
Copy link
Contributor

I did a clean install from the generator and updated to 0.12.11. Then I adjusted the test bootstrap to use sails.load() instead of sails.lift() which is recommended by sails as the tests use sails.request() anyhow.

That way the test/boostrap.js becomes this:

"use strict";

const Sails = require('sails');
const config = require('../config/env/test');

before(done => {
  Sails.load(config, (error) => {
    if (error) return done(error);

    done();
  });
});

And everything works with sails 12 :)

@ghaiklor
Copy link
Owner

@BraunreutherA can you create a small PR, so I can publish a new version? :)

@mikedevita
Copy link
Contributor Author

PR is inbound for @BraunreutherA's proposed fixes i'm just testing the final parts now.

ghaiklor pushed a commit that referenced this issue Dec 27, 2017
* update sails dependency version to 0.12.14

* update bootstrap.js to use Sails.load instead of Sails.lifta

* cleanup of bootstrap.js fixed Sails.lower and 

unused sails variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants