Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for targeting the visible part of wrapped last lines #57

Open
rktjmp opened this issue Sep 26, 2021 · 2 comments
Open

Allow for targeting the visible part of wrapped last lines #57

rktjmp opened this issue Sep 26, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@rktjmp
Copy link
Contributor

rktjmp commented Sep 26, 2021

NVIM v0.6.0-dev+266-g5fd21b8d3
Lightspeed: 27625ea

If I have some very long lines which are wrapped, lightspeed doesn't seem to let me search everything visible. This may be a deliberate limitation for performance?

It's easier to see with a video. I have 3 lines. From line 1, I can only "query" (with s) into lines 1 and 2. From line 2, I can only query into line 2. I think it's to do with line 3 ending off screen?

lightspeed-2021-09-27_03.08.01.mp4

(if embed is broken https://streamable.com/rvs7as)

Content used, but any long, wrapped content will work.

Ipsum accusamus minus totam eum aliquid. Nisi animi accusantium nam suscipit mollitia. Quae animi veritatis at ex unde! Natus doloribus ducimus mollitia provident facere Pariatur hic omnis adipisci eos consequuntur Ipsum accusamus minus totam eum aliquid. Nisi animi accusantium nam suscipit mollitia. Quae animi veritatis at ex unde! Natus doloribus ducimus mollitia provident facere Pariatur hic omnis adipisci eos consequuntur Ipsum accusamus minus totam eum aliquid. Nisi animi accusantium nam suscipit mollitia. Quae animi veritatis at ex unde! Natus doloribus ducimus mollitia provident facere Pariatur hic omnis adipisci eos consequuntur Ipsum accusamus minus totam eum aliquid. Nisi animi accusantium nam suscipit mollitia. Quae animi veritatis at ex unde! Natus doloribus ducimus mollitia provident facere Pariatur hic omnis adipisci eos consequuntur Ipsum accusamus minus totam eum aliquid. Nisi animi accusantium nam suscipit mollitia. Quae animi veritatis at ex unde! Natus doloribus ducimus mollitia provident facere Pariatur hic omnis adipisci eos consequuntur Ipsum accusamus minus totam eum aliquid. Nisi animi accusantium nam suscipit mollitia. Quae animi veritatis at ex unde! Natus doloribus ducimus mollitia provident facere Pariatur hic omnis adipisci eos consequuntur Ipsum accusamus minus totam eum aliquid. Nisi animi accusantium nam suscipit mollitia. Quae animi veritatis at ex unde! Natus doloribus ducimus mollitia provident facere Pariatur hic omnis adipisci eos consequuntur Ipsum accusamus minus totam eum aliquid. Nisi animi accusantium nam suscipit mollitia.
Consectetur autem cupiditate nemo harum pariatur! Vero unde adipisci velit aperiam in. Nostrum aspernatur eligendi hic praesentium optio Tenetur officiis aperiam non necessitatibus architecto Beatae sit ex dolor doloremque doloribus. Consectetur autem cupiditate nemo harum pariatur! Vero unde adipisci velit aperiam in. Nostrum aspernatur eligendi hic praesentium optio Tenetur officiis aperiam non necessitatibus architecto Beatae sit ex dolor doloremque doloribus. Consectetur autem cupiditate nemo harum pariatur! Vero unde adipisci velit aperiam in. Nostrum aspernatur eligendi hic praesentium optio Tenetur officiis aperiam non necessitatibus architecto Beatae sit ex dolor doloremque doloribus. Consectetur autem cupiditate nemo harum pariatur! Vero unde adipisci velit aperiam in. Nostrum aspernatur eligendi hic praesentium optio Tenetur officiis aperiam non necessitatibus architecto Beatae sit ex dolor doloremque doloribus.
Adipisicing consequuntur obcaecati dolorem quae reprehenderit Perspiciatis reiciendis architecto molestiae odio corporis Architecto soluta optio quaerat expedita expedita. Neque voluptate tempora magni consectetur suscipit ea. Architecto nihil vitae delectus a? Adipisicing consequuntur obcaecati dolorem quae reprehenderit Perspiciatis reiciendis architecto molestiae odio corporis Architecto soluta optio quaerat expedita expedita. Neque voluptate tempora magni consectetur suscipit ea. Architecto nihil vitae delectus a? Adipisicing consequuntur obcaecati dolorem quae reprehenderit Perspiciatis reiciendis architecto molestiae odio corporis Architecto soluta optio quaerat expedita expedita. Neque voluptate tempora magni consectetur suscipit ea. Architecto nihil vitae delectus a? Adipisicing consequuntur obcaecati dolorem quae reprehenderit Perspiciatis reiciendis architecto molestiae odio corporis Architecto soluta optio quaerat expedita expedita. Neque voluptate tempora magni consectetur suscipit ea. Architecto nihil vitae delectus a? Adipisicing consequuntur obcaecati dolorem quae reprehenderit Perspiciatis reiciendis architecto molestiae odio corporis Architecto soluta optio quaerat expedita expedita. Neque volupccctate tempora magni consectetur suscipit ea. Architecto nihil vitae delectus a? Adipisicing consequuntur obcaecati dolorem quae reprehenderit Perspiciatis reiciendis architecto molestiae odio corporis Architecto soluta optio quaerat expedita expedita. Neque voluptate tempora magni consectetur suscipit ea. Architecto nihil vitae delectus a?
@rktjmp rktjmp changed the title Long, wrapped lines limit search scope Unable to search all visible characters with long, wrapped lines Sep 26, 2021
@ggandor
Copy link
Owner

ggandor commented Sep 26, 2021

I think it's to do with line 3 ending off screen?

Yep, it's not part of the window area technically, i.e., it's beyond vim.fn.line("w$"). We could just include the whole w$+1 line in the search area of course, but we don't want to register (and label) invisible positions, we should know where the visible part ends.

This may be a deliberate limitation for performance?

Not at all, it's just not trivial to handle this. (EasyMotion has an open issue about this for a while now.) I'm not saying it's a terribly complex problem, I just haven't got the time to think it through yet. But this is on my todo list.

@ggandor ggandor changed the title Unable to search all visible characters with long, wrapped lines Allow for targeting the visible part of a wrapped last line Sep 28, 2021
@ggandor ggandor added enhancement New feature or request help wanted Extra attention is needed labels Sep 28, 2021
@ggandor ggandor changed the title Allow for targeting the visible part of a wrapped last line Allow for targeting the visible part of wrapped last lines Sep 28, 2021
@ggandor
Copy link
Owner

ggandor commented Oct 3, 2021

Someone just raised the issue in vim-sneak too. I hoped Justin will have an idea on how to handle this, but it's only the w$ + 1 workaround at the moment...

@ggandor ggandor added bug Something isn't working and removed enhancement New feature or request labels Oct 9, 2021
@ggandor ggandor removed the bug Something isn't working label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants