Skip to content

fix(eap): Handle vcc filtering #98655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(eap): Handle vcc filtering #98655

wants to merge 2 commits into from
+59 −18

Conversation

wmak
Copy link
Member

@wmak wmak commented Sep 2, 2025

  • We were filtering based on the underlying values for VCCs which caused issues with how Nulls were handled.
  • This updates the filtering to be based on the resulting values instead by not resolving the column which handles these filters better

@wmak
fix(eap): Handle vcc filtering
bc38601 
- We were filtering based on the underlying values for VCCs which caused
  issues with how Nulls were handled.
- This updates the filtering to be based on the resulting values instead
  by not resolving the column which handles these filters better
@wmak wmak requested a review from a team as a code owner September 2, 2025 21:05
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 2, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #98655     +/-   ##
=========================================
  Coverage   81.19%   81.19%             
=========================================
  Files        8524     8535     +11     
  Lines      375534   376805   +1271     
  Branches    23877    23877             
=========================================
+ Hits       304908   305946   +1038     
- Misses      70258    70491    +233     
  Partials      368      368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wmak