feat(replay): query IP for trace connected errors for replay summary (v2) #98479
+541
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
This comment was marked as off-topic.
This comment was marked as off-topic.
michellewzhang
force-pushed
the
mz/fix-ip-query
branch
from
0e2b665 to
345fddc
Compare
aliu39
changed the title
aliu39
reviewed
Aug 28, 2025
aliu39
reviewed
Aug 28, 2025
|
Branching off this and adding better tracing/logging to debug |
aliu39
reviewed
Aug 28, 2025
michellewzhang
commented
Sep 2, 2025
michellewzhang
commented
Sep 2, 2025
Wrap the methods of this endpoint with a custom transaction. Sampling rates will be options-controlled. We need a high POST sample rate while we develop this feature, to debug slow loading times. I believe options can be segmented by user email, or something like is_employee - will experiment Merge with #98479
michellewzhang
commented
Sep 2, 2025
aliu39
reviewed
Sep 3, 2025
michellewzhang
commented
Sep 3, 2025
|
|
||
| # Process issuePlatform query results | ||
| if issue_query_results and "data" in issue_query_results: |
There was a problem hiding this comment.
is there a chance the query results don't exist?
There was a problem hiding this comment.
I think that's only when snuba errors, and we should raise rather than silently skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redo of #97737
reverted the old pr as the trace id query was too slow -- it did 2 snuba queries per trace id (bad). this pr instead makes it 2 total queries for all trace ids
MERGE WED