feat(member merge): set email_unique on User object save #92696

mifu67 · 2025-06-02T22:55:29Z

We should wait until we've merged the changes setting sentry app and heroku user placeholder emails to merge this change. Requires #92655 to be merged.

codecov · 2025-06-24T20:43:59Z

❌ 36 Tests Failed:

Tests completed	Failed	Passed	Skipped
27551	36	27515	597

View the top 3 failed test(s) by shortest run time

tests.sentry.users.models.test_user.UserDetailsTest::test_email_unique

Stack Traces | 0.253s run time

#x1B[1m#x1B[.../users/models/test_user.py#x1B[0m:189: in test_email_unique
    with pytest.raises(IntegrityError):
#x1B[1m#x1B[31mE   Failed: DID NOT RAISE <class 'django.db.utils.IntegrityError'>#x1B[0m

tests.sentry.db.test_transactions.TestPytestDjangoDbAll::test_collect_transaction_queries[MONOLITH]

Stack Traces | 0.5s run time

#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:105: in _execute
    return self.cursor.execute(sql, params)
#x1B[1m#x1B[.../db/postgres/decorators.py#x1B[0m:16: in inner
    return func(self, *args, **kwargs)
#x1B[1m#x1B[.../db/postgres/base.py#x1B[0m:95: in execute
    return self.cursor.execute(sql, params)
#x1B[1m#x1B[31mE   psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint "auth_user_email_unique_key"#x1B[0m
#x1B[1m#x1B[31mE   DETAIL:  Key (email_unique)=() already exists.#x1B[0m

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m
#x1B[1m#x1B[.../sentry/db/test_transactions.py#x1B[0m:158: in test_collect_transaction_queries
    super().test_collect_transaction_queries()
#x1B[1m#x1B[.../sentry/db/test_transactions.py#x1B[0m:41: in test_collect_transaction_queries
    User.objects.create(username="user3")
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:663: in create
    obj.save(force_insert=True, using=self.db)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[.../users/models/user.py#x1B[0m:250: in save
    result = super().save(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../contrib/auth/base_user.py#x1B[0m:65: in save
    super().save(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:902: in save
    self.save_base(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:1008: in save_base
    updated = self._save_table(
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:1169: in _save_table
    results = self._do_insert(
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:1210: in _do_insert
    return manager._insert(
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1864: in _insert
    return query.get_compiler(using=using).execute_sql(returning_fields)
#x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/compiler.py#x1B[0m:1882: in execute_sql
    cursor.execute(sql, params)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:122: in execute
    return super().execute(sql, params)
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/sentry_sdk/utils.py#x1B[0m:1814: in runner
    return original_function(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:79: in execute
    return self._execute_with_wrappers(
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:92: in _execute_with_wrappers
    return executor(sql, params, many, context)
#x1B[1m#x1B[.../db/postgres/base.py#x1B[0m:70: in _execute__include_sql_in_error
    return execute(sql, params, many, context)
#x1B[1m#x1B[.../db/postgres/base.py#x1B[0m:58: in _execute__clean_params
    return execute(sql, clean_bad_params(params), many, context)
#x1B[1m#x1B[.../sentry/testutils/hybrid_cloud.py#x1B[0m:133: in __call__
    return execute(*params)
#x1B[1m#x1B[.../sentry/testutils/hybrid_cloud.py#x1B[0m:174: in __call__
    return execute(query, *args)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:100: in _execute
    with self.db.wrap_database_errors:
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/db/utils.py#x1B[0m:91: in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:105: in _execute
    return self.cursor.execute(sql, params)
#x1B[1m#x1B[.../db/postgres/decorators.py#x1B[0m:16: in inner
    return func(self, *args, **kwargs)
#x1B[1m#x1B[.../db/postgres/base.py#x1B[0m:95: in execute
    return self.cursor.execute(sql, params)
#x1B[1m#x1B[31mE   django.db.utils.IntegrityError: duplicate key value violates unique constraint "auth_user_email_unique_key"#x1B[0m
#x1B[1m#x1B[31mE   DETAIL:  Key (email_unique)=() already exists.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   SQL: INSERT INTO "auth_user" ("password", "last_login", "username", "first_name", "email", "email_unique", "is_staff", "is_active", "is_unclaimed", "is_superuser", "is_managed", "is_sentry_app", "is_password_expired", "last_password_change", "flags", "session_nonce", "date_joined", "last_active", "avatar_type", "avatar_url") VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s) RETURNING "auth_user"."id", "auth_user"."is_unclaimed", "auth_user"."avatar_type", "auth_user"."avatar_url"#x1B[0m

tests.sentry.db.test_transactions.TestDjangoTestCaseTransactions::test_collect_transaction_queries

Stack Traces | 0.514s run time

#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:105: in _execute
    return self.cursor.execute(sql, params)
#x1B[1m#x1B[.../db/postgres/decorators.py#x1B[0m:16: in inner
    return func(self, *args, **kwargs)
#x1B[1m#x1B[.../db/postgres/base.py#x1B[0m:95: in execute
    return self.cursor.execute(sql, params)
#x1B[1m#x1B[31mE   psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint "auth_user_email_unique_key"#x1B[0m
#x1B[1m#x1B[31mE   DETAIL:  Key (email_unique)=() already exists.#x1B[0m

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m
#x1B[1m#x1B[.../sentry/db/test_transactions.py#x1B[0m:41: in test_collect_transaction_queries
    User.objects.create(username="user3")
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:663: in create
    obj.save(force_insert=True, using=self.db)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[.../users/models/user.py#x1B[0m:250: in save
    result = super().save(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../contrib/auth/base_user.py#x1B[0m:65: in save
    super().save(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:902: in save
    self.save_base(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:1008: in save_base
    updated = self._save_table(
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:1169: in _save_table
    results = self._do_insert(
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:1210: in _do_insert
    return manager._insert(
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1864: in _insert
    return query.get_compiler(using=using).execute_sql(returning_fields)
#x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/compiler.py#x1B[0m:1882: in execute_sql
    cursor.execute(sql, params)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:122: in execute
    return super().execute(sql, params)
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/sentry_sdk/utils.py#x1B[0m:1814: in runner
    return original_function(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:79: in execute
    return self._execute_with_wrappers(
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:92: in _execute_with_wrappers
    return executor(sql, params, many, context)
#x1B[1m#x1B[.../db/postgres/base.py#x1B[0m:70: in _execute__include_sql_in_error
    return execute(sql, params, many, context)
#x1B[1m#x1B[.../db/postgres/base.py#x1B[0m:58: in _execute__clean_params
    return execute(sql, clean_bad_params(params), many, context)
#x1B[1m#x1B[.../sentry/testutils/hybrid_cloud.py#x1B[0m:133: in __call__
    return execute(*params)
#x1B[1m#x1B[.../sentry/testutils/hybrid_cloud.py#x1B[0m:174: in __call__
    return execute(query, *args)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:100: in _execute
    with self.db.wrap_database_errors:
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/db/utils.py#x1B[0m:91: in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/backends/utils.py#x1B[0m:105: in _execute
    return self.cursor.execute(sql, params)
#x1B[1m#x1B[.../db/postgres/decorators.py#x1B[0m:16: in inner
    return func(self, *args, **kwargs)
#x1B[1m#x1B[.../db/postgres/base.py#x1B[0m:95: in execute
    return self.cursor.execute(sql, params)
#x1B[1m#x1B[31mE   django.db.utils.IntegrityError: duplicate key value violates unique constraint "auth_user_email_unique_key"#x1B[0m
#x1B[1m#x1B[31mE   DETAIL:  Key (email_unique)=() already exists.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   SQL: INSERT INTO "auth_user" ("password", "last_login", "username", "first_name", "email", "email_unique", "is_staff", "is_active", "is_unclaimed", "is_superuser", "is_managed", "is_sentry_app", "is_password_expired", "last_password_change", "flags", "session_nonce", "date_joined", "last_active", "avatar_type", "avatar_url") VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s) RETURNING "auth_user"."id", "auth_user"."is_unclaimed", "auth_user"."avatar_type", "auth_user"."avatar_url"#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

getsantry · 2025-07-16T07:00:19Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 2, 2025

cathteng approved these changes Jun 12, 2025

View reviewed changes

leedongwei approved these changes Jun 23, 2025

View reviewed changes

mifu67 force-pushed the mifu67/member-merge/set-email-unique branch from b03a175 to 5508132 Compare June 24, 2025 20:33

vercel bot deployed to Preview June 24, 2025 20:35 View deployment

mifu67 added 3 commits June 24, 2025 15:46

set email_unique on save

52ecc91

try catch

9cbefa7

test

d48c141

mifu67 force-pushed the mifu67/member-merge/set-email-unique branch from 5508132 to d48c141 Compare June 24, 2025 22:48

vercel bot deployed to Preview June 24, 2025 22:49 View deployment

getsantry bot added the Stale label Jul 16, 2025

mifu67 added the WIP label Jul 16, 2025

Merge branch 'master' into mifu67/member-merge/set-email-unique

3246704

mifu67 removed WIP Stale labels Sep 2, 2025

vercel bot deployed to Preview September 2, 2025 18:53 View deployment

logic updates, hack for tests

d3c5ab8

vercel bot deployed to Preview September 2, 2025 22:19 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(member merge): set email_unique on User object save #92696

feat(member merge): set email_unique on User object save #92696

mifu67 commented Jun 2, 2025

Uh oh!

codecov bot commented Jun 24, 2025 •

edited

Loading

Uh oh!

getsantry bot commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

feat(member merge): set email_unique on User object save #92696

Are you sure you want to change the base?

feat(member merge): set email_unique on User object save #92696

Conversation

mifu67 commented Jun 2, 2025

Uh oh!

codecov bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 36 Tests Failed:

Uh oh!

getsantry bot commented Jul 16, 2025

Uh oh!

Uh oh!

codecov bot commented Jun 24, 2025 •

edited

Loading