Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several instances of "first seen" and other fields assume an ordered input. #5289

Open
tkaemming opened this issue Apr 24, 2017 · 6 comments

Comments

@tkaemming
Copy link
Contributor

tkaemming commented Apr 24, 2017

While doing some research on supporting fingerprint disassociation, I found many columns that assume that the event input stream is ordered by the event occurrence time. This assumption is incorrect for a lot of reasons, but mobile traffic is probably the most significant one.

This applies to at least the following columns (this list is not necessarily exhaustive):

  • Group.first_seen
  • Group.last_seen
  • Group.first_release
  • Group.score, since this is derived from Group.last_seen
  • GroupRelease.first_seen
  • ReleaseEnvironment.first_seen
  • TagValue.first_seen (uses wall clock time, rather than event time)
  • TagValue.last_seen (uses wall clock time, rather than event time)
  • GroupTagValue.first_seen (uses wall clock time, rather than event time)
  • GroupTagValue.last_seen (uses wall clock time, rather than event time)
@tkaemming
Copy link
Contributor Author

I also just realized that this is going to be the case for reprocessed events, which can be delayed up to 10 days by default.

@tkaemming
Copy link
Contributor Author

{,Group}TagValue.{first,last}_seen also use the current wall clock time for mutations, rather than the provided event timestamp.

@tkaemming
Copy link
Contributor Author

tkaemming commented Jun 29, 2017

This "last-write-wins by the receiving server wall clock time" behavior can also yield some confusing behavior for group fields like culprit, message, level, etc. (basically any of these fields) when comparing the group details with the reverse chronologically sorted "related events" list.

@BYK
Copy link
Member

BYK commented Oct 20, 2020

Closing this issue due to staleness. Feel free to comment here if you think we should still work on this.

@BYK BYK closed this as completed Oct 20, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
@untitaker untitaker reopened this Apr 28, 2021
@untitaker
Copy link
Member

This is still an issue.

@untitaker
Copy link
Member

Another fun fact is that first_seen on GroupEnvironment is updated with the current time instead of the event's timestamp in the same way that Group.first_seen is.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants