Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching module update for RedisIntegration #2965

Closed
1 task
Tracked by #2949
antonpirker opened this issue Apr 10, 2024 · 1 comment
Closed
1 task
Tracked by #2949

Caching module update for RedisIntegration #2965

antonpirker opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
Enhancement New feature or request Integration: Redis

Comments

@antonpirker
Copy link
Member

antonpirker commented Apr 10, 2024

To make spans created by the RedisIntegration eligible for the "Cache Module" in Sentry Perfromance include more data when cache_spans is enabled.

Please follow the specification found here:
https://develop.sentry.dev/sdk/performance/modules/caches/

Part of #2949

Bonus:

  • Load test the cache spans generation and publish results somewhere to be confident that this will not add to much overhead.
@antonpirker antonpirker added the Enhancement New feature or request label Apr 10, 2024
@antonpirker antonpirker changed the title Caching Module update for RedisIntegration Caching module update for RedisIntegration Apr 10, 2024
@antonpirker antonpirker self-assigned this Apr 10, 2024
@antonpirker
Copy link
Member Author

This issue has been solved in the two PRs mentioned above. Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Integration: Redis
Projects
None yet
Development

No branches or pull requests

1 participant