-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Enhancements to Queue instrumentation #2951
Labels
Enhancement
New feature or request
Comments
This was referenced Apr 9, 2024
antonpirker
changed the title
Enhancements to Queue instrumentation
[Python] Enhancements to Queue instrumentation
Apr 9, 2024
szokeasaurusrex
added a commit
that referenced
this issue
Apr 26, 2024
szokeasaurusrex
added a commit
that referenced
this issue
Apr 30, 2024
szokeasaurusrex
added a commit
that referenced
this issue
May 3, 2024
szokeasaurusrex
added a commit
that referenced
this issue
May 3, 2024
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
added a commit
that referenced
this issue
May 3, 2024
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
added a commit
that referenced
this issue
May 3, 2024
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
added a commit
that referenced
this issue
May 3, 2024
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
added a commit
that referenced
this issue
May 3, 2024
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
added a commit
that referenced
this issue
May 3, 2024
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
added a commit
that referenced
this issue
May 7, 2024
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
added a commit
that referenced
this issue
May 7, 2024
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
added a commit
that referenced
this issue
May 7, 2024
szokeasaurusrex
added a commit
that referenced
this issue
May 7, 2024
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
added a commit
that referenced
this issue
May 10, 2024
szokeasaurusrex
added a commit
that referenced
this issue
May 10, 2024
szokeasaurusrex
added a commit
that referenced
this issue
May 10, 2024
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
added a commit
that referenced
this issue
May 15, 2024
Set the "messaging.system" data on the "queue.process" span in the Celery integration. The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. Also, add tests for this feature. ref #2951
This issue can be closed because the Celery integration was updated to emit spans that are eligible for the new Insights Queues module. (see mentioned PRs above) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We want to improve the data we collect for task queues.
We will start with enhancing our Celery integration. This should work with redis, and rabbitmq, and as a stretch goal amazon sqs as brokers. (Kafka should follow later.)
How spans are right now:
<span op="queue.submit.celery">
when task is put into queue. (start_timestamp
is when putting into queue is started andend_timestamp
is when the item is in the queue.)<transaction op="queue.task.celery">
when task is fetched and processed. (start_timestamp
is when the item was received from the queue,end_timestamp
is when the processing of the task has finished. )ok
in case of successaborted
if Celery raises Retry, Ignore or Reject celery exceptionsinternal_error
if an unhandled exception was raised during execution of the taskNew data we want to add to queue spans:
(for naming see: https://opentelemetry.io/docs/specs/semconv/attributes-registry/messaging/)
args
of existing_wrap_tracer
, the attached PR)messaging.message.body.size
)messaging.message.envelope.size
)server.address
) - (can be found inargs
of existing_wrap_tracer
, the attached PR)messaging.destination.name
) - not sure where to get this.messaging.message.id
) - should also be inargs
of the comments in the attached PR)messaging.client_id
) - dont know yet where to get.messaging.system
)See this PR for some points where to get the data: #2962
I also added a sample project that uses RabbitMQ with Celery: https://github.com/antonpirker/testing-sentry/tree/main/test-celery-queues-module
Mock of how it will look in the product:
Tasks
The text was updated successfully, but these errors were encountered: