Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] TanStack Start SDK #14990

Open
3 tasks
mydea opened this issue Jan 13, 2025 · 4 comments
Open
3 tasks

[JavaScript] TanStack Start SDK #14990

mydea opened this issue Jan 13, 2025 · 4 comments
Assignees

Comments

@mydea
Copy link
Member

mydea commented Jan 13, 2025

Description

We already have a router instrumentation for TanStack Router, but we also want to add a proper e.g. @sentry/tanstack SDK.

Currently, TanStack Start relies on Vinxi on the backend but this will be replaced by Nitro before TanStack Start releases version 1.0.0.

  • Add a guide in docs about manually setting this up
  • Add to in-product onboarding for manually setting this up
  • Add actual proper SDK, eventually - this will need proper Nitro support!
@KiwiKilian
Copy link

KiwiKilian commented Feb 4, 2025

@mydea FYI, Start is working on removing the Vinxi deps:

Vinxi will be removed before version 1.0.0 is released and TanStack will rely only on Vite and Nitro. The commands and APIs that use Vinxi will likely be replaced with a Vite plugin or dedicated TanStack Start CLI.

We are looking forward to use Sentry with TanStack Start React.

@nickmanks
Copy link

+1 👍

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Feb 10, 2025
@lforst lforst self-assigned this Feb 27, 2025
@lforst lforst changed the title TanStack Start SDK [JavaScript] TanStack Start SDK Feb 27, 2025
@lforst lforst pinned this issue Feb 28, 2025
@kieranm
Copy link

kieranm commented Mar 2, 2025

Would love some guidance on setting up the source maps properly, too! I can't get this to work with the standard Sentry vite plugin right now:

[plugin vite-plugin-tanstack-start-ensure-global-middleware] Sourcemap is likely to be incorrect: a plugin (vite-plugin-tanstack-start-ensure-global-middleware) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help (x194)

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Mar 2, 2025
@lforst
Copy link
Member

lforst commented Mar 3, 2025

@kieranm I haven't looked at sourcemaps yet but will write a guide soon. Until then, this particular warning would require fixing upstream in vite-plugin-tanstack-start-ensure-global-middleware. But, I should also note that this is merely a warning and does not indicate that sourcemaps will not work at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

7 participants