-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile: User.Other is included in managed errors but not native ones #3340
Labels
Comments
came from a customer, cc @JLuse ^ |
Documenting the pitfall won't fix bad UX. And looking at what
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using the SDK's C# API to change the Scope, we're able to pass down some fields to the native layer.
So if a crash is caused by Java/Kotlin/Objective-C/Swift/C/C++ etc, it'll include User top level firleds and tags.
How it works: Setting the user in C# triggers the ScopeObserver:
sentry-dotnet/src/Sentry/Scope.cs
Lines 120 to 139 in 5f0f087
So on iOS for example, we'll set the user as such:
sentry-dotnet/src/Sentry/Platforms/Cocoa/CocoaScopeObserver.cs
Lines 92 to 103 in 5f0f087
On Android:
sentry-dotnet/src/Sentry/Platforms/Android/AndroidScopeObserver.cs
Lines 90 to 100 in 5f0f087
And Native (
[sentry-native](https://github.com/getsentry/sentry-native)
):sentry-dotnet/src/Sentry/Platforms/Native/NativeScopeObserver.cs
Lines 30 to 39 in 5f0f087
But we don't include everything, and that's not documented anywhere it seems.
For example, we don't sync down to native
User.Other
. And this can be a pitfall to customers.We need to at least clearly document this, or expand scope sync for this field.
The text was updated successfully, but these errors were encountered: